Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzip does not support pathlib #72414

Closed
ethanfurman opened this issue Sep 21, 2016 · 8 comments
Closed

gzip does not support pathlib #72414

ethanfurman opened this issue Sep 21, 2016 · 8 comments
Assignees
@berkerpeksag
Labels
3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error

Comments

@ethanfurman
Copy link
Member

BPO 28227
Nosy @brettcannon, @ned-deily, @ethanfurman, @berkerpeksag, @serhiy-storchaka
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•
    Files
  • open-gzip.stoneleaf.patch
  • issue28227_v2.diff
  • issue28227_v3.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2016-10-02.10:47:36.007>
created_at = <Date 2016-09-21.07:29:26.835>
labels = ['type-bug', '3.7']
title = 'gzip does not support pathlib'
updated_at = <Date 2017-03-31.16:36:14.045>
user = 'https://github.com/ethanfurman'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:14.045>
actor = 'dstufft'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2016-10-02.10:47:36.007>
closer = 'berker.peksag'
components = []
creation = <Date 2016-09-21.07:29:26.835>
creator = 'ethan.furman'
dependencies = []
files = ['44769', '44926', '44927']
hgrepos = []
issue_num = 28227
keywords = ['patch']
message_count = 8.0
messages = ['277110', '277865', '277876', '277879', '277881', '277883', '277884', '277885']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ned.deily', 'ethan.furman', 'python-dev', 'berker.peksag', 'serhiy.storchaka']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28227'
versions = ['Python 3.6', 'Python 3.7']
    @ethanfurman ethanfurman added the type-bug An unexpected behavior, bug, or error label Sep 21, 2016
    @serhiy-storchaka
    Copy link
    Member

    Since patches for gzip, bz2 and lzma are too similar, I think it is worth to merge them in one patch.

    @ned-deily ned-deily added the 3.7 (EOL) end of life label Sep 23, 2016
    @berkerpeksag
    Copy link
    Member

    I've addressed all of Serhiy's review comments. Thanks!

    @serhiy-storchaka
    Copy link
    Member

    You missed one my comment. GzipFile.name is not converted in write mode.

    @berkerpeksag
    Copy link
    Member

    You're right. I definitely missed that one. Here is an updated patch. Thanks again!

    @berkerpeksag
    Copy link
    Member

    By the way, for some reason it doesn't show up at https://bugs.python.org/review/28227/patch/18629/74286

    @serhiy-storchaka
    Copy link
    Member

    The patch LGTM.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 2, 2016

    New changeset 3f71d1a93053 by Berker Peksag in branch '3.6':
    Issue bpo-28227: gzip now supports pathlib
    https://hg.python.org/cpython/rev/3f71d1a93053

    New changeset b244bf74b638 by Berker Peksag in branch 'default':
    Issue bpo-28227: Merge from 3.6
    https://hg.python.org/cpython/rev/b244bf74b638

    @berkerpeksag
    Copy link
    Member

    Thanks Ethan and Serhiy.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @berkerpeksag berkerpeksag

    Labels
    3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @berkerpeksag @serhiy-storchaka @ned-deily @ethanfurman