Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change URL in antigravity library file #72368

Closed
sivaraam mannequin opened this issue Sep 16, 2016 · 5 comments
Closed

Change URL in antigravity library file #72368

sivaraam mannequin opened this issue Sep 16, 2016 · 5 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@sivaraam
Copy link
Mannequin

sivaraam mannequin commented Sep 16, 2016

BPO 28181
Nosy @tiran, @sivaraam
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•
    Files
  • antigravity-patch.patch: patch that changes URL in antigravity.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-09-16.11:54:52.109>
created_at = <Date 2016-09-16.11:25:00.354>
labels = ['3.7', 'type-bug', 'library']
title = 'Change URL in antigravity library file'
updated_at = <Date 2017-03-31.16:36:32.070>
user = 'https://github.com/sivaraam'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:32.070>
actor = 'dstufft'
assignee = 'none'
closed = True
closed_date = <Date 2016-09-16.11:54:52.109>
closer = 'christian.heimes'
components = ['Library (Lib)']
creation = <Date 2016-09-16.11:25:00.354>
creator = 'kaartic'
dependencies = []
files = ['44690']
hgrepos = []
issue_num = 28181
keywords = ['patch']
message_count = 5.0
messages = ['276695', '276696', '276704', '276705', '276712']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'python-dev', 'kaartic']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28181'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']
    @sivaraam
    Copy link
    Mannequin Author

    sivaraam mannequin commented Sep 16, 2016

    I use a network that is monitored and filtered by Cyberoam. The use Cyberoam to block some websites, and some content.

    I came to know of the antigravity easter egg recently. I tried it using 'import antigravity' and it opened the xkcd website as expected, but did not display the picture. I was able to view the image, when I changed the URL from http://xkcd.com/353 to https://xkcd.com/353
    I found that I could not view the image as Cyberoam (for some unknown reason) blocked the loading of the picture for the HTTP site.

    If it does not cause any compatibility issue or other issues, please change the URL in the antigravity library also to a HTTPS one. I request you to change this as this may go unnoticed to other people who are not aware of it.

    I have attached a patch that changes the URL. You may use it if it's ok changing the URL.

    @sivaraam sivaraam mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Sep 16, 2016
    @tiran
    Copy link
    Member

    tiran commented Sep 16, 2016

    xkcd redirects http to https. It makes sense to fix the module and use https.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 16, 2016

    New changeset b8ac4ee42ad3 by Christian Heimes in branch '3.5':
    Issue bpo-28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam.
    https://hg.python.org/cpython/rev/b8ac4ee42ad3

    New changeset 0820d023077e by Christian Heimes in branch '3.6':
    Issue bpo-28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam.
    https://hg.python.org/cpython/rev/0820d023077e

    New changeset 7ebd6271094d by Christian Heimes in branch 'default':
    Issue bpo-28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam.
    https://hg.python.org/cpython/rev/7ebd6271094d

    New changeset 742a798c4da6 by Christian Heimes in branch 'default':
    Issue bpo-28181: Add Kaartic Sivaraam to Misc/ACKS.
    https://hg.python.org/cpython/rev/742a798c4da6

    @tiran
    Copy link
    Member

    tiran commented Sep 16, 2016

    Thanks for your contribution!

    @tiran tiran closed this as completed Sep 16, 2016
    @sivaraam
    Copy link
    Mannequin Author

    sivaraam mannequin commented Sep 16, 2016

    Don't Mention. It was my long time wish to contribute to open source projects.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran