Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows build to xz-5.2.2 #72252

Closed
zware opened this issue Sep 10, 2016 · 4 comments
Closed

Update Windows build to xz-5.2.2 #72252

zware opened this issue Sep 10, 2016 · 4 comments
Assignees
@zware
Labels
build The build process and cross-build OS-windows type-feature A feature request or enhancement

Comments

@zware
Copy link
Member

zware commented Sep 10, 2016

BPO 28065
Nosy @pfmoore, @tjguk, @zware, @zooba
Files
  • build_xz.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zware'
closed_at = <Date 2016-09-12.02:18:59.225>
created_at = <Date 2016-09-10.18:42:10.309>
labels = ['type-feature', 'OS-windows', 'build']
title = 'Update Windows build to xz-5.2.2'
updated_at = <Date 2016-09-12.02:18:59.224>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2016-09-12.02:18:59.224>
actor = 'zach.ware'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2016-09-12.02:18:59.225>
closer = 'zach.ware'
components = ['Build', 'Windows']
creation = <Date 2016-09-10.18:42:10.309>
creator = 'zach.ware'
dependencies = []
files = ['44534']
hgrepos = []
issue_num = 28065
keywords = ['patch']
message_count = 4.0
messages = ['275670', '275786', '275916', '275917']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28065'
versions = ['Python 3.6']
    @zware
    Copy link
    Member Author

    zware commented Sep 10, 2016

    Attached patch builds xz-5.2.2 ourselves rather than relying on pre-built binaries. It copies the project file from xz and modifies it to fit our setup, so updates may not be a 3 line change like a sqlite3 update.

    This is rather beta-quality, I'm sure there's some cleanup that can be done. If nobody gets a chance to look at it before tomorrow, I'm going to sneak it in anyway before b1.

    @zware zware self-assigned this Sep 10, 2016
    @zware zware added build The build process and cross-build OS-windows type-feature A feature request or enhancement labels Sep 10, 2016
    @tjguk
    Copy link
    Member

    tjguk commented Sep 11, 2016

    Applies, builds & tests ok for me for Win32 Release build (ie build.bat
    -e) on Win 8.1 x64.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 12, 2016

    New changeset f06e7501e530 by Zachary Ware in branch 'default':
    Issue bpo-28065: Update xz to 5.2.2 on Windows, and build it from source
    https://hg.python.org/cpython/rev/f06e7501e530

    @zware
    Copy link
    Member Author

    zware commented Sep 12, 2016

    Thanks for trying it out, Tim!

    @zware zware closed this as completed Sep 12, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zware zware

    Labels
    build The build process and cross-build OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @tjguk @zware