Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up division fast paths in Objects/longobject.c #72247

Open
mdickinson opened this issue Sep 10, 2016 · 6 comments
Open

Clean up division fast paths in Objects/longobject.c #72247

mdickinson opened this issue Sep 10, 2016 · 6 comments
Labels
3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@mdickinson
Copy link
Member

BPO 28060
Nosy @mdickinson, @pitrou, @serhiy-storchaka
Files
  • divmod_fastpath.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2016-09-10.10:46:13.057>
labels = ['performance']
title = 'Clean up division fast paths in Objects/longobject.c'
updated_at = <Date 2017-07-22.10:09:56.204>
user = 'https://github.com/mdickinson'

    bugs.python.org fields:

    activity = <Date 2017-07-22.10:09:56.204>
actor = 'mark.dickinson'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2016-09-10.10:46:13.057>
creator = 'mark.dickinson'
dependencies = []
files = ['44528']
hgrepos = []
issue_num = 28060
keywords = ['patch']
message_count = 6.0
messages = ['275618', '275619', '275675', '275679', '298843', '298845']
nosy_count = 3.0
nosy_names = ['mark.dickinson', 'pitrou', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'commit review'
status = 'open'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue28060'
versions = ['Python 3.6']
    @mdickinson
    Copy link
    Member Author

    We seem to have ended up with redundant fast path checks for division in longobject.c: long_div has a fast path check, but the long_div slow path calls l_divmod, which then does a second, identical, fast path check. long_mod has similar behaviour. long_divmod, however, has no fast path, so relies on the one from l_divmod.

    This patch removes the extra fast path from l_divmod, and then adds a top-level fast path check to long_divmod.

    @mdickinson mdickinson self-assigned this Sep 10, 2016
    @mdickinson mdickinson added the performance Performance or resource usage label Sep 10, 2016
    @mdickinson
    Copy link
    Member Author

    N.B. The patch also tweaks the fast path condition to *include* the common case of a dividend of 0, and *exclude* the rare case of a negative divisor. (The latter change helps to keep the fast path code simple.)

    @mdickinson
    Copy link
    Member Author

    Serhiy: thanks for the review. Replying here, since I get a 500 error every time I try to reply from Rietveld.

    I'd rather not rely on either NSMALLPOSINTS > 0 or on digit 0 existing when Py_SIZE is 0. We don't rely on that elsewhere, and the code should stay simple where possible.

    @serhiy-storchaka
    Copy link
    Member

    The patch LGTM. I'll open separate issue for guaranteeing that a->ob_digit[0] is 0 in case of Py_SIZE(a) == 0 and using this fact for simplifying and optimizing the code.

    @pitrou
    Copy link
    Member

    pitrou commented Jul 22, 2017

    What's the status of this?

    @mdickinson
    Copy link
    Member Author

    What's the status of this?

    Forgotten, rather than abandoned. :-( I'll unassign so that someone else can pick this up. I believe the patch is ready to go, except that of course now it needs a PR.

    @mdickinson mdickinson removed their assignment Jul 22, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @iritkatriel iritkatriel added 3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 31, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @mdickinson @iritkatriel @pitrou @serhiy-storchaka