Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 530, asynchronous comprehensions implementation #72195

Closed
1st1 opened this issue Sep 7, 2016 · 7 comments
Closed

PEP 530, asynchronous comprehensions implementation #72195

1st1 opened this issue Sep 7, 2016 · 7 comments
Assignees
@1st1
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Sep 7, 2016

BPO 28008
Nosy @vstinner, @ned-deily, @ambv, @1st1
Files
  • async_comp_1.patch
  • asyncomp.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
closed_at = <Date 2016-09-11.17:43:06.865>
created_at = <Date 2016-09-07.21:15:27.039>
labels = ['interpreter-core', 'type-feature']
title = 'PEP 530, asynchronous comprehensions implementation'
updated_at = <Date 2016-09-11.17:43:06.864>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2016-09-11.17:43:06.864>
actor = 'ned.deily'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2016-09-11.17:43:06.865>
closer = 'ned.deily'
components = ['Interpreter Core']
creation = <Date 2016-09-07.21:15:27.039>
creator = 'yselivanov'
dependencies = []
files = ['44451', '44504']
hgrepos = []
issue_num = 28008
keywords = ['patch']
message_count = 7.0
messages = ['274897', '275358', '275359', '275361', '275384', '275385', '275416']
nosy_count = 5.0
nosy_names = ['vstinner', 'ned.deily', 'lukasz.langa', 'python-dev', 'yselivanov']
pr_nums = []
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28008'
versions = ['Python 3.6']
    @1st1
    Copy link
    Member Author

    1st1 commented Sep 7, 2016

    This patch is supposed to be committed after issue bpo-28003.

    @1st1 1st1 self-assigned this Sep 7, 2016
    @1st1 1st1 added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Sep 7, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 9, 2016

    New changeset cf91a929b81a by Yury Selivanov in branch 'default':
    Issue bpo-28008: Implement PEP-530 -- asynchronous comprehensions.
    https://hg.python.org/cpython/rev/cf91a929b81a

    @1st1
    Copy link
    Member Author

    1st1 commented Sep 9, 2016

    Committed. Thank you Victor for the review.

    @1st1 1st1 closed this as completed Sep 9, 2016
    @vstinner
    Copy link
    Member

    vstinner commented Sep 9, 2016

    You are not done yet :-)

    http://buildbot.python.org/all/builders/s390x%20SLES%203.x/builds/1762/steps/test/logs/stdio

    ======================================================================
    FAIL: test_files (test.test_tools.test_unparse.DirectoryTestCase)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_unparse.py", line 297, in test_files
    self.check_roundtrip(source)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_unparse.py", line 132, in check_roundtrip
    self.assertASTEqual(ast1, ast2)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_unparse.py", line 124, in assertASTEqual
    self.assertEqual(ast.dump(ast1), ast.dump(ast2))
AssertionError: 'Modu[156588 chars]sync=1)]))], decorator_list=[], returns=None),[36372 chars]])])' != 'Modu[156588 chars]sync=0)]))], decorator_list=[], returns=None),[36372 chars]])])'

    @vstinner vstinner reopened this Sep 9, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 9, 2016

    New changeset 223c134af5a1 by Yury Selivanov in branch 'default':
    Issue bpo-28008: Fix test_unparse
    https://hg.python.org/cpython/rev/223c134af5a1

    @1st1
    Copy link
    Member Author

    1st1 commented Sep 9, 2016

    Should be fixed now.

    @1st1
    Copy link
    Member Author

    1st1 commented Sep 9, 2016

    Build bots are green now, closing this.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @1st1 1st1

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @1st1 @ned-deily