Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate building with bundled copy of libffi on non-Darwin POSIX platforms #72163

Closed
zware opened this issue Sep 6, 2016 · 6 comments
Closed

Deprecate building with bundled copy of libffi on non-Darwin POSIX platforms #72163

zware opened this issue Sep 6, 2016 · 6 comments
Labels
build The build process and cross-build topic-ctypes type-feature A feature request or enhancement

Comments

@zware
Copy link
Member

zware commented Sep 6, 2016

BPO 27976
Nosy @malemburg, @doko42, @tjguk, @ned-deily, @bitdancer, @meadori, @cjerdonek, @xdegaye, @berkerpeksag, @zware, @koobs, @zooba, @yan12125
Files
  • deprecate_bundled_libffi.diff
  • issue27976.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-09-10.00:01:35.487>
created_at = <Date 2016-09-06.17:56:22.387>
labels = ['ctypes', 'type-feature', 'build']
title = 'Deprecate building with bundled copy of libffi on non-Darwin POSIX platforms'
updated_at = <Date 2016-09-10.00:01:35.485>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2016-09-10.00:01:35.485>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2016-09-10.00:01:35.487>
closer = 'python-dev'
components = ['Build', 'ctypes']
creation = <Date 2016-09-06.17:56:22.387>
creator = 'zach.ware'
dependencies = []
files = ['44399', '44455']
hgrepos = []
issue_num = 27976
keywords = ['patch']
message_count = 6.0
messages = ['274576', '274627', '274628', '274761', '274926', '275504']
nosy_count = 17.0
nosy_names = ['lemburg', 'doko', 'tim.golden', 'ned.deily', 'Arfrever', 'r.david.murray', 'meador.inge', 'chris.jerdonek', 'xdegaye', 'python-dev', 'berker.peksag', 'zach.ware', 'koobs', 'steve.dower', 'gustavotemple', 'fabiovmp', 'yan12125']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27976'
versions = ['Python 3.6']
    @zware
    Copy link
    Member Author

    zware commented Sep 6, 2016

    Nosy list copied from bpo-23085.

    Here's a patch that deprecates building _ctypes with the bundled copy of libffi (Modules/_ctypes/libffi/). The default on all platforms (other than Windows) is now to use a system copy of libffi; use the '--without-system-ffi' flag to ./configure to use the bundled copy. On non-Darwin platforms, a warning will be emitted noting that Modules/_ctypes/libffi will not be distributed with 3.7.

    @zware zware added build The build process and cross-build type-feature A feature request or enhancement topic-ctypes labels Sep 6, 2016
    @berkerpeksag
    Copy link
    Member

    +1, thanks for working on this!

    Two questions:

    1. Should we check the system version of libffi and warn users (and probably use the bundled version for now) if it was older than 3.1?

    2. I know this isn't directly a user-facing feature, but should we add a short note to Doc/whatsnew/3.6.rst? (we can probably mention that most of the Linux distributions already use --with-system-ffi.)

    @zware
    Copy link
    Member Author

    zware commented Sep 6, 2016

    I don't think it's worthwhile to do a version check and warning, especially since we'll be removing the bundled version in 3.7. A docs note is worthwhile, though, I'll attach a new patch shortly.

    @yan12125
    Copy link
    Mannequin

    yan12125 mannequin commented Sep 7, 2016

    That's great! bpo-26942 can be closed after this change is landed. It's caused by a libffi bug on Android.

    @zware
    Copy link
    Member Author

    zware commented Sep 8, 2016

    Finally got a new patch created. After talking it over with Ned yesterday, this patch makes sure that nothing changes on OSX.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 10, 2016

    New changeset 3e02187e50df by Zachary Ware in branch 'default':
    Closes bpo-27976: Deprecate bundled full copy of libffi
    https://hg.python.org/cpython/rev/3e02187e50df

    @python-dev python-dev mannequin closed this as completed Sep 10, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build topic-ctypes type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @zware