Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_PyGen_Finalize() should not fail with an exception #71998

Closed
arigo mannequin opened this issue Aug 20, 2016 · 4 comments
Closed

_PyGen_Finalize() should not fail with an exception #71998

arigo mannequin opened this issue Aug 20, 2016 · 4 comments

Comments

@arigo
Copy link
Mannequin

arigo mannequin commented Aug 20, 2016

BPO 27811
Nosy @arigo, @benjaminp
Files
  • patch1.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-09-05.17:17:51.078>
created_at = <Date 2016-08-20.09:35:05.512>
labels = []
title = '_PyGen_Finalize() should not fail with an exception'
updated_at = <Date 2016-09-05.20:22:58.014>
user = 'https://github.com/arigo'

    bugs.python.org fields:

    activity = <Date 2016-09-05.20:22:58.014>
actor = 'arigo'
assignee = 'none'
closed = True
closed_date = <Date 2016-09-05.17:17:51.078>
closer = 'python-dev'
components = []
creation = <Date 2016-08-20.09:35:05.512>
creator = 'arigo'
dependencies = []
files = ['44165']
hgrepos = []
issue_num = 27811
keywords = ['patch', 'needs review']
message_count = 4.0
messages = ['273199', '274407', '274408', '274428']
nosy_count = 3.0
nosy_names = ['arigo', 'benjamin.peterson', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue27811'
versions = ['Python 3.6']
    @arigo
    Copy link
    Mannequin Author

    arigo mannequin commented Aug 20, 2016

    _PyGen_Finalize() should not fail with an exception. Doing so can cause various SystemErrors or even fatal errors. For example, run this with "python -Werror":

        import gc
    async def f():
        pass
    f()
    gc.collect()   # RuntimeWarning, but with -Werror

    Patch attached. Test missing (turn the above example in a test; also I didn't re-run all tests with this patch).

    @benjaminp
    Copy link
    Contributor

    Thank you, Armin.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 5, 2016

    New changeset 4d531711cbc7 by Benjamin Peterson in branch '3.5':
    do not allow _PyGen_Finalize to fail (closes bpo-27811)
    https://hg.python.org/cpython/rev/4d531711cbc7

    New changeset 1b14dbe9e98b by Benjamin Peterson in branch 'default':
    merge 3.5 (closes bpo-27811)
    https://hg.python.org/cpython/rev/1b14dbe9e98b

    @python-dev python-dev mannequin closed this as completed Sep 5, 2016
    @arigo
    Copy link
    Mannequin Author

    arigo mannequin commented Sep 5, 2016

    You're welcome. Unrelated, but I'm collecting similar issues in a file at http://bitbucket.org/pypy/extradoc/raw/extradoc/planning/py3.5/cpython-crashers.rst . After reporting the first two, I stopped, and will report them all in bulk some time later, but you may be interested in fixing a couple more for the upcoming 3.6 release.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @benjaminp