Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyd icon for 3.6 #71943

Closed
AraHaan mannequin opened this issue Aug 13, 2016 · 10 comments
Closed

Add pyd icon for 3.6 #71943

AraHaan mannequin opened this issue Aug 13, 2016 · 10 comments
Assignees
@zooba
Labels
OS-windows type-feature A feature request or enhancement

Comments

@AraHaan
Copy link
Mannequin

AraHaan mannequin commented Aug 13, 2016

BPO 27756
Nosy @pfmoore, @tjguk, @zware, @eryksun, @zooba, @AraHaan
Files
  • pyd.ico
  • ProposedIcons.png
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2016-09-05.21:10:18.734>
created_at = <Date 2016-08-13.20:26:13.827>
labels = ['type-feature', 'OS-windows']
title = 'Add pyd icon for 3.6'
updated_at = <Date 2016-09-05.21:52:04.222>
user = 'https://github.com/AraHaan'

    bugs.python.org fields:

    activity = <Date 2016-09-05.21:52:04.222>
actor = 'python-dev'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2016-09-05.21:10:18.734>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2016-08-13.20:26:13.827>
creator = 'Decorater'
dependencies = []
files = ['44098', '44129']
hgrepos = []
issue_num = 27756
keywords = []
message_count = 10.0
messages = ['272613', '272813', '272815', '272817', '272890', '272892', '272893', '274431', '274432', '274440']
nosy_count = 7.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'eryksun', 'steve.dower', 'Decorater']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27756'
versions = ['Python 3.6']
    @AraHaan
    Copy link
    Mannequin Author

    AraHaan mannequin commented Aug 13, 2016

    I did some working and did a halfed one for pyd's it basically combines it icon from python.exe with the DLL "gears" for windows DLL's beig under that. Hopefully it will work. (Anyone could use this as a base file and restyle it or whatever if they want. At least I tried.

    (note: the file would have to go under the PC directory as well. Hopefully something from the python installer can associate them with pyd files so that way people can distinquish them from any other file type (like pdbs,lib,w/e with no icon(s)).

    @zooba
    Copy link
    Member

    zooba commented Aug 16, 2016

    It's certainly very easy to add an icon for pyd files. The tricky part is getting an icon we can redistribute - fairly sure one derived from a Windows icon is not redistributable.

    Let me see if I can get one of the designers at work to put something together. Maybe it's time for a whole new set :)

    @eryksun
    Copy link
    Contributor

    eryksun commented Aug 16, 2016

    Maybe it's time for a whole new set :)

    Please keep a rocket in the upper left-hand corner for the launcher icon. It distinguishes the launcher from other "Python" apps when modifying the shell's file association, since the shell doesn't show the command-line template to the user. Of course, it would also help if the description in py.exe were changed to "Python Launcher" instead of just "Python".

    @zooba
    Copy link
    Member

    zooba commented Aug 16, 2016

    Can't promise there'll be a rocket, but the launcher icon will certainly be different from the source file icon.

    @zooba
    Copy link
    Member

    zooba commented Aug 16, 2016

    Got an impressively quick response from one of our willing designers, who has proposed the attached icons.

    In order, they would be:

    • pythonw.exe
    • py.exe (for reference, this mimics the Run launcher icon in Win10)
    • All .py
    • python.exe
    • All .pyc
    • All .pyd

    Any suggestions or comments? I personally think they look great.

    @zooba zooba self-assigned this Aug 16, 2016
    @zooba zooba added the type-feature A feature request or enhancement label Aug 16, 2016
    @eryksun
    Copy link
    Contributor

    eryksun commented Aug 16, 2016

    Should pyw.exe get its own icon? Otherwise these look good to me; they're less busy than the existing icons, which is probably for the best. Is there a potential licensing problem with borrowing the look of the Win+R dialog icon, or is this fair use?

    @zooba
    Copy link
    Member

    zooba commented Aug 16, 2016

    It's probably not worth doing pyw.exe - even distinguishing between python.exe and pythonw.exe is only possible because we came up with that icon before the alternative one for the launcher.

    The style just imitates the icon in the Run dialog (the "feeling of speed"), it's not the same image. Only the Python logo is a concern, but we're allowed to use that one :)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 5, 2016

    New changeset 29815771f2ac by Steve Dower in branch 'default':
    Issue bpo-27756: Adds new icons for Python files and processes on Windows. Designs by Cherry Wang.
    https://hg.python.org/cpython/rev/29815771f2ac

    @zooba
    Copy link
    Member

    zooba commented Sep 5, 2016

    The new beautiful icons have been checked in!

    @zooba zooba closed this as completed Sep 5, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 5, 2016

    New changeset 386aa9738c6b by Steve Dower in branch 'default':
    Issue bpo-27756: Updates installer icons to be the console and launcher icon instead of the setup icon
    https://hg.python.org/cpython/rev/386aa9738c6b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @eryksun @zooba @ned-deily