Implement PEP 3108 #47024

brettcannon · 2008-05-06T18:11:09Z

BPO	2775
Nosy	@freddrake, @warsaw, @brettcannon, @birkenfeld, @kbkaiser, @pitrou, @avassalotti, @hdiogenes, @benjaminp, @orivej, @juracy, @merwok, @florentx, @meadori, @ericsnowcurrently
Dependencies	bpo-2874: Remove use of the stat module in the stdlib bpo-3260: fix_imports does not handle intra-package renames
Files	symtable_removed_on_py3k.diff: symtable/_symtable removed on py3000 deprecated_symtable_on_py26.patch: symtable/_symtable deprecated warnings added for python 2.6 htmllib_removed_on_py3k.diff: htmllib removed in py3000 http_package_on_py3k.diff: Patch for http package for py3000 http_package_on_py3k.status: SVN status for http package patch on py3000 renaming_leftovers_2.6.patch: Patch against trunk (r63318) import_renames_py3k.patch: Patch for some imports in py3k setup.py.remove-bsddb.diff: Remove bsddb build code zipfile-patch.diff: Fixing zipfile.BadZipfile to zipfile.BadZipFile

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2012-11-17.15:05:49.421>
created_at = <Date 2008-05-06.18:11:08.731>
labels = ['type-bug', 'library']
title = 'Implement PEP 3108'
updated_at = <Date 2012-11-17.15:05:49.419>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2012-11-17.15:05:49.419>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2012-11-17.15:05:49.421>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2008-05-06.18:11:08.731>
creator = 'brett.cannon'
dependencies = ['2874', '3260']
files = ['10292', '10294', '10297', '10324', '10325', '10326', '10416', '14434', '19222']
hgrepos = []
issue_num = 2775
keywords = ['patch']
message_count = 71.0
messages = ['66326', '66330', '66340', '66341', '66342', '66348', '66520', '66538', '66540', '66565', '66567', '66568', '66570', '66574', '66588', '66599', '66602', '66603', '66646', '66660', '66695', '66696', '66698', '66701', '66815', '66816', '66822', '66823', '66840', '66841', '66842', '66849', '66893', '66911', '66915', '66917', '66961', '67025', '67032', '67070', '67085', '67156', '67160', '67234', '67268', '68035', '68041', '68970', '69061', '83489', '90043', '90051', '97812', '97847', '118566', '118573', '118654', '118688', '118863', '118949', '118956', '119598', '119624', '119641', '124777', '147624', '147632', '147689', '149079', '149094', '175751']
nosy_count = 22.0
nosy_names = ['jhylton', 'fdrake', 'barry', 'brett.cannon', 'georg.brandl', 'kbk', 'pitrou', 'alexandre.vassalotti', 'hdiogenes', 'quentin.gallet-gilles', 'benjamin.peterson', 'gpolo', 'orivej', 'jnoller', 'andrewsmedina', 'juracy@gmail.com', 'eric.araujo', 'henry.precheur', 'Retro', 'flox', 'meador.inge', 'eric.snow']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = 'needs patch'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2775'
versions = ['Python 3.3']

brettcannon · 2008-05-06T18:11:07Z

This is to keep track of who is working on what for PEP-3108
(http://www.python.org/dev/peps/pep-3108/). Once something is complete it
should be denoted in the PEP itself, so always check the PEP to see what
is left to be done (for both 2.6 and 3.0).

jhylton · 2008-05-06T20:12:02Z

I'm working on the new urllib package.

benjaminp · 2008-05-06T22:59:35Z

I'm working on removing mac modules.

brettcannon · 2008-05-06T23:02:56Z

I am working on audiodev to get the basic structure of removals worked out
(testing infrastructure, etc.).

brettcannon · 2008-05-06T23:12:01Z

For the TextMate users, I am going to be checking in a Python-Dev bundle
into svn soon which will include a command to insert the warnpy3k() call
for module deletions. Might want to wait for that if you want to cut out
at least one copy-and-paste step. =)

brettcannon · 2008-05-06T23:55:13Z

If you use TextMate, get the Python-Dev bundle and use the command in
there to insert the deprecation boilerplate for removing a module.

andrewsmedina · 2008-05-10T13:45:02Z

I'm working on removing symtable/_symtable

juracy · 2008-05-10T15:53:40Z

I'm working on creating http package with httplib, BaseHTTPServer,
CGIHTTPServer, SimpleHTTPServer, Cookie and cookielib

jnoller · 2008-05-10T16:19:20Z

Here is a patch for the Queue module renaming - I can not easily do the
actual svn rename to the lowercase queue myself (it's easier to do it with
commit privs). Tests pass, documentation updated as well.

jnoller · 2008-05-10T19:04:42Z

Here is a patch for the required changes to rename SocketServer.py - tests
pass after I manually rename SocketServer.py locally. Again skipping the
svn rename of the actual module. Doc updates included.

jnoller · 2008-05-10T19:16:32Z

I'm working on xmlrpc/* changes

jhylton · 2008-05-10T19:24:41Z

I think we should move robotparser into the urllib package. Anyone
disagree?

Jeremy

jnoller · 2008-05-10T19:29:47Z

Should DocXMLRPCServer.py be moved into xmlrpc/ as well?

brettcannon · 2008-05-10T19:52:09Z

On Sat, May 10, 2008 at 12:29 PM, Jesse Noller <report@bugs.python.org> wrote:

Jesse Noller <jnoller@gmail.com> added the comment:

Should DocXMLRPCServer.py be moved into xmlrpc/ as well?

Yes, and end up in the server module. That was just an oversight on my
part. The PEP has been updated.

andrewsmedina · 2008-05-10T21:48:22Z

I add deprecated warnings symtable/_symtable in python 2.6

brettcannon · 2008-05-11T03:39:28Z

Just so people know, I have emailed python-dev about renaming urllib as I
realized there are some issues with the solution proposed in the PEP.

andrewsmedina · 2008-05-11T06:33:00Z

The files Python/compile.c and Python/pythonrun.c depends of the
_symtable (Python/symtable.c and Include/symtable.h).

What I do for remove _symtable in py3k?

hdiogenes · 2008-05-11T06:54:13Z

Andrews, this discussion would be more appropriate to the mailing list,
but anyway: I believe you're mixing things up. When PEP-3108 says "remove
symtable/_symtable", it must be talking only about symtable.py and
symtablemodule.c, not symtable.[ch] (used by the compiler).

gpolo · 2008-05-11T17:54:19Z

I'm working on the new package tkinter and dialogs merging where
appropriate.

gpolo · 2008-05-11T20:15:47Z

Patch regarding the move to tkinter package added.

What this patch does
--------------------

Moved lib-tk to tkinter and renamed modules according to PEP-3108
Merged tkFileDialog into filedialog
Merged tkSimpleDialog into simpledialog
Updated imports in pydoc
Updated imports in idlelib
Updated imports in Tools and Demos
Changed lib-tk to tkinter at Makefile.pre.in
Removed TKPATH from Modules/Setup.dist
Removed references of lib-tk at PC/

What has to be done
-------------------

Update iss script at PC/ to change lib-tk to tkinter
Update docs
stub modules ?

andrewsmedina · 2008-05-12T01:40:06Z

I'm working on creating html package with HTMLParser and htmlentitydefs

brettcannon · 2008-05-12T01:45:17Z

Just so people know, feel free to create new issues for stuff if you want.
Other issues can be made dependencies of this issue very easily.

gpolo · 2008-05-12T02:01:20Z

New patch regarding the move to tkinter package, now with docs updated.
This one should be the "final" patch, and while the patch is relatively
large it mostly trivial to review.

andrewsmedina · 2008-05-12T02:19:23Z

For to remove the htmllib on Python 3000 is need to removed these files:

Lib/htmllib.py
Lib/test_htmllib.py

And apply this patch

quentingallet-gilles · 2008-05-14T11:59:03Z

I'm working on renaming the ConfigParser module.

avassalotti · 2008-06-11T23:07:45Z

Done with pickle and stringio.

warsaw · 2008-06-12T02:08:12Z

We've got what we've got for the first betas.

orivej · 2008-06-29T21:34:24Z

Not creating new bug entry because everybody can quickly fix it.

In urllib/request.py some instances of URLError are raised with "raise
urllib.error.URLError" and this works, buth there are lines with "raise
URLError" which produces "NameError: global name 'URLError' is not defined"

birkenfeld · 2008-07-01T19:56:44Z

Fixed in r64624.

brettcannon · 2009-03-12T07:07:13Z

For those of you following along, the only thing keeping PEP-3108 and
this issue from being finished are the two dependent issues: os.stat and
profile/cProfile.

henryprecheur · 2009-07-03T04:10:29Z

I found some bsddb code left in setup.py. Patch attached.

benjaminp · 2009-07-03T13:23:05Z

Thanks for the patch. Applied in r738067.

florentx · 2010-01-15T14:01:31Z

Modules "hotshot" and "xmllib" give deprecation warnings. But they are not part of PEP-3108 or PEP-4.

brettcannon · 2010-01-15T21:14:39Z

I don't know why hotshot was deprecated specifically for Python 3 as that was never directly part of the discussion for PEP-3108. As for xmllib, that is most likely an oversight. Either way they should get added to the relevant PEPs.

Retro · 2010-10-13T19:30:52Z

I am very glad you're reorganizing the Standard Library. Thumbs up! I hope everything will comply to PEP-8 after you're done.

Since you're reorganizing, I have my own contribution. I have uploaded a patch. The bpo-7351 (http://bugs.python.org/issue7351) was not accepted at the time, I hope you'll accept this fix now.

My point is that every class name in module zipfile is like this:

exception class: LargeZipFile
normal class: ZipFile
normal class: PyZipFile

So apply my fix to make the exception class BadZipfile consistent to others and let it be BadZipFile.

Thank you.

brettcannon · 2010-10-13T20:04:15Z

The reorganization is over short of one or two lasting changes that may not even be made now. New suggestions are not directly being discussed here and would have to be taken up on python-dev.

Retro · 2010-10-14T12:11:30Z

Can you send my patch and comment to python-dev? Because I don't know how to. I don't know where is python-dev and what exactly you mean by this.

brettcannon · 2010-10-14T16:43:13Z

No. Best I can do is suggest you perform an internet search on the term as it makes it obvious what python-dev is.

Retro · 2010-10-16T10:29:07Z

My patch "zipfile-patch.diff" was sent to python-dev. Please act on it as you see fit. Thank you.

Retro · 2010-10-17T16:12:38Z

Did you manage to apply my fix "zipfile-patch.diff" to the trunk?

brettcannon · 2010-10-17T17:57:25Z

If any action regarding your patch takes place there will be a comment here about it. Until then assume nothing has happened.

pitrou · 2010-10-26T10:43:52Z

Shouldn't this be closed? Most of this has been done and we can't do the rest anyway, without breaking backwards compatibility.

brettcannon · 2010-10-26T17:48:40Z

profile and cProfile could still conceivably be merged, even if it is under a new name if someone found the time to do the compatibility work.

birkenfeld · 2010-10-26T19:27:20Z

I will have a go at the profiler situation.

I imagine the following: deprecate the cProfile module, and provide both profiler classes from the profile module -- e.g. as PythonProfile and CProfile, and provide Profile = PythonProfile. (From cProfile.py, obviously Profile = CProfile). A lot of the interface (module-level helpers and script entry) are near duplicated anyway.

In 3.3, the default Profile could then be reassigned to CProfile.

birkenfeld · 2010-12-28T10:10:56Z

Alas, too late for 3.2 now.

brettcannon · 2011-11-14T17:59:05Z

Just so people know, if the profile situation isn't resolved by 3.3 I'm considering PEP-3108 done.

IOW, if anyone wants to step forward and deal with cProfile/profile, that would be appreciated. =)

ericsnowcurrently · 2011-11-14T20:53:37Z

For the stat module in the "Obsolete" section[1], should the entry be updated to indicate that the module was left alone (see bpo-2874)?

Would it be worth having the "Merging C and Python Impl..." section[2] include a reference to PEP-399?

[1] http://www.python.org/dev/peps/pep-3108/#obsolete
[2] http://www.python.org/dev/peps/pep-3108/#merging-c-and-python-implementations-of-the-same-interface

brettcannon · 2011-11-15T17:03:34Z

Answers to Eric's questions: yes and yes, but I probably won't bother until I do a final update to the PEP.

avassalotti · 2011-12-09T07:08:01Z

Brett, bpo-2919 had a patch that merges profile/cProfile for a while now but nobody test it yet.

All I need it someone to download the patch, install it, test it on some random script and tell me if it works. I don't need more.

pitrou · 2011-12-09T13:42:08Z

Brett, bpo-2919 had a patch that merges profile/cProfile for a while
now but nobody test it yet.

All I need it someone to download the patch, install it, test it on
some random script and tell me if it works. I don't need more.

I don't see any patch there, only a .tgz and two Python files.

brettcannon · 2012-11-17T15:05:49Z

I think we are as close as we are going to get with PEP-3018 being implemented. if profile/cProfile ever get merged that is great (issue bpo-16492), but I'm not holding my breath and thus I am closing this issue.

brettcannon added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 6, 2008

brettcannon self-assigned this May 6, 2008

brettcannon added the easy label May 6, 2008

brettcannon added the release-blocker label May 11, 2008

warsaw removed the release-blocker label Jun 12, 2008

merwok removed the easy label Nov 18, 2010

brettcannon closed this as completed Nov 17, 2012

ezio-melotti transferred this issue from another repository Apr 10, 2022

Implement PEP 3108 #47024

Implement PEP 3108 #47024

Comments

brettcannon commented May 6, 2008

brettcannon commented May 6, 2008

jhylton mannequin commented May 6, 2008

benjaminp commented May 6, 2008

brettcannon commented May 6, 2008

brettcannon commented May 6, 2008

brettcannon commented May 6, 2008

andrewsmedina mannequin commented May 10, 2008

juracy mannequin commented May 10, 2008

jnoller mannequin commented May 10, 2008

jnoller mannequin commented May 10, 2008

jnoller mannequin commented May 10, 2008

jhylton mannequin commented May 10, 2008

jnoller mannequin commented May 10, 2008

brettcannon commented May 10, 2008

andrewsmedina mannequin commented May 10, 2008

brettcannon commented May 11, 2008

andrewsmedina mannequin commented May 11, 2008

hdiogenes mannequin commented May 11, 2008

gpolo mannequin commented May 11, 2008

gpolo mannequin commented May 11, 2008

andrewsmedina mannequin commented May 12, 2008

brettcannon commented May 12, 2008

gpolo mannequin commented May 12, 2008

andrewsmedina mannequin commented May 12, 2008

quentingallet-gilles mannequin commented May 14, 2008

avassalotti commented Jun 11, 2008

warsaw commented Jun 12, 2008

orivej mannequin commented Jun 29, 2008

birkenfeld commented Jul 1, 2008

brettcannon commented Mar 12, 2009

henryprecheur mannequin commented Jul 3, 2009

benjaminp commented Jul 3, 2009

florentx mannequin commented Jan 15, 2010

brettcannon commented Jan 15, 2010

Retro mannequin commented Oct 13, 2010

brettcannon commented Oct 13, 2010

Retro mannequin commented Oct 14, 2010

brettcannon commented Oct 14, 2010

Retro mannequin commented Oct 16, 2010

Retro mannequin commented Oct 17, 2010

brettcannon commented Oct 17, 2010

pitrou commented Oct 26, 2010

brettcannon commented Oct 26, 2010

birkenfeld commented Oct 26, 2010

birkenfeld commented Dec 28, 2010

brettcannon commented Nov 14, 2011

ericsnowcurrently commented Nov 14, 2011

brettcannon commented Nov 15, 2011

avassalotti commented Dec 9, 2011

pitrou commented Dec 9, 2011

brettcannon commented Nov 17, 2012