Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_cProfile #46993

Closed
benjaminp opened this issue May 2, 2008 · 14 comments
Closed

Fix test_cProfile #46993

benjaminp opened this issue May 2, 2008 · 14 comments

Comments

@benjaminp
Copy link
Contributor

BPO 2744
Nosy @warsaw, @brettcannon, @mdickinson, @avassalotti, @benjaminp

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-11-17.17:06:14.982>
created_at = <Date 2008-05-02.23:15:09.867>
labels = []
title = 'Fix test_cProfile'
updated_at = <Date 2012-11-17.17:06:14.982>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2012-11-17.17:06:14.982>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2012-11-17.17:06:14.982>
closer = 'brett.cannon'
components = []
creation = <Date 2008-05-02.23:15:09.867>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 2744
keywords = []
message_count = 14.0
messages = ['66131', '66168', '68016', '70481', '70667', '72417', '72470', '74391', '74395', '74396', '74397', '109475', '111996', '111999']
nosy_count = 6.0
nosy_names = ['barry', 'brett.cannon', 'mark.dickinson', 'alexandre.vassalotti', 'benjamin.peterson', 'BreamoreBoy']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2744'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

@benjaminp
Copy link
Contributor Author

test_cProfile has been disabled in Py3k for a while now. It should be
fixed before release.

@brettcannon
Copy link
Member

A key thing to realize is that test_cprofile has heavily changed in
2.6 compared to what is currently disabled in 3.0.

@avassalotti
Copy link
Member

I will try to fix this one with profile/cProfile merge.

@avassalotti avassalotti self-assigned this Jun 11, 2008
@benjaminp
Copy link
Contributor Author

Alexandre, are you still computerless?

@avassalotti
Copy link
Member

Not anymore! :-)

@nnorwitz nnorwitz mannequin added the release-blocker label Aug 24, 2008
@brettcannon
Copy link
Member

So is this going to be a 3.1 issue or a 3.0 one? If it's the former then
it should not be a release blocker. But if is going to be for 3.0 then
the version list is wrong.

@warsaw
Copy link
Member

warsaw commented Sep 4, 2008

I guess since this hasn't been done by now, it's not going to get done
for 3.0, so I'm lowering the priority on it.

@benjaminp
Copy link
Contributor Author

Done in r66817.

@avassalotti
Copy link
Member

Have you verified the numbers? They don't look right to me.

The problem is the 2nd argument of cProfile's constructor has a
different semantic meaning than the one for profile.py. For profile.py,
it is used to set the "bias" (I presume it means the overhead) of the
profiler. But for cProfile, it's the unit (in seconds?) of timer used.

Personally, I have no idea which semantic should be preferred. So
perhaps, the best thing to do for now is remove the second argument from
the cls.profilerclass() call in test_profile.ProfileTest:

class ProfileTest:
    ...
    def do_profiling(cls):
        ...
        prof = cls.profilerclass(timer, 0.001)
        ...

@benjaminp
Copy link
Contributor Author

No, I didn't look too hard at it; I just got it scraping along, so I can
forward port a fix for it. I'll reopen this, so you can take more
action, so you wish. :)

@benjaminp benjaminp reopened this Oct 6, 2008
@avassalotti
Copy link
Member

Unassigning myself as I don't have the time to fix this properly.

@avassalotti avassalotti removed their assignment Oct 6, 2008
@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Jul 7, 2010

Is there anybody who can run with this as it's been in limbo for over two years?

@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Jul 29, 2010

Nobody has responded to msg109475 so I'll close unless there are any objections.

@mdickinson
Copy link
Member

I'll close unless there are any objections.

Yes, I object! :)

If there's still a bug present, it seems inappropriate to close this issue. So as a first step, someone needs to look at this closely to determine whether there *is* still a problem that needs fixing. (It's not clear to me at the moment whether that's true.)

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants