Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests break with --with-system-expat and Expat 2.2.0 #71556

Closed
hartwork mannequin opened this issue Jun 22, 2016 · 4 comments
Closed

Tests break with --with-system-expat and Expat 2.2.0 #71556

hartwork mannequin opened this issue Jun 22, 2016 · 4 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@hartwork
Copy link
Mannequin

hartwork mannequin commented Jun 22, 2016

BPO 27369
Nosy @vadmium, @hartwork, @yan12125
Files
  • 0001-Fix-Python-2.7.11-tests-for-Expat-2.2.0.patch: Patch for 2.7.11
  • 0001-Fix-Python-3.x.x-tests-for-Expat-2.2.0.patch: Patch for 3.x.x
  • issue27369.patch: Patch that uses assertRaisesRegex, target the default branch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-07-14.04:11:32.662>
created_at = <Date 2016-06-22.18:17:23.662>
labels = ['type-bug', 'tests']
title = 'Tests break with --with-system-expat and Expat 2.2.0'
updated_at = <Date 2016-07-14.04:58:59.910>
user = 'https://github.com/hartwork'

    bugs.python.org fields:

    activity = <Date 2016-07-14.04:58:59.910>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-07-14.04:11:32.662>
closer = 'benjamin.peterson'
components = ['Tests']
creation = <Date 2016-06-22.18:17:23.662>
creator = 'sping'
dependencies = []
files = ['43514', '43515', '43652']
hgrepos = []
issue_num = 27369
keywords = ['patch']
message_count = 4.0
messages = ['269079', '269093', '269927', '270357']
nosy_count = 4.0
nosy_names = ['python-dev', 'martin.panter', 'sping', 'yan12125']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27369'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4', 'Python 3.5', 'Python 3.6']
    @hartwork
    Copy link
    Mannequin Author

    hartwork mannequin commented Jun 22, 2016

    Expat commit
    https://sourceforge.net/p/expat/code_git/ci/550eb6bbaa7e6efc44e94cab945fe9c781c01211 introduced with the recent release of Expat 2.2.0 fixed a bug that the current Python test suite relies on.

    Attached you find patches to fix the test suite for all versions in a backwards-compatible way. Please consider application upstream. Thanks!

    Best, Sebastian

    @hartwork hartwork mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jun 22, 2016
    @vadmium
    Copy link
    Member

    vadmium commented Jun 22, 2016

    Thanks for the patches. This test was added in r74435, presumably to test for a crash. IMO it would be sufficient to test for the first part of the error message, without checking the column number. The test could also use assertRaisesRegex().

    Should this actually be applied to all security versions, or just 3.5+ and 2.7? I guess can see the benefit of fixing 3.2+, and I remember doing this once before when the test suite fell over and it was not Python’s fault.

    @yan12125
    Copy link
    Mannequin

    yan12125 mannequin commented Jul 7, 2016

    Added a patch.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 14, 2016

    New changeset 5b64175c6c24 by Martin Panter in branch '3.2':
    Issue bpo-27369: Don’t test error message detail that changed in Expat 2.2.0
    https://hg.python.org/cpython/rev/5b64175c6c24

    New changeset 1c06e02b968a by Martin Panter in branch '3.3':
    Issue bpo-27369: Merge test_pyexpat from 3.2 into 3.3
    https://hg.python.org/cpython/rev/1c06e02b968a

    New changeset 17ec4d58c046 by Martin Panter in branch '3.4':
    Issue bpo-27369: Merge test_pyexpat from 3.3 into 3.4
    https://hg.python.org/cpython/rev/17ec4d58c046

    New changeset 2d6e6600c210 by Martin Panter in branch '2.7':
    Issue bpo-27369: Don’t test error message detail that changed in Expat 2.2.0
    https://hg.python.org/cpython/rev/2d6e6600c210

    New changeset 0fbf3b88eed8 by Martin Panter in branch '3.5':
    Issue bpo-27369: Merge test_pyexpat from 3.4 into 3.5
    https://hg.python.org/cpython/rev/0fbf3b88eed8

    New changeset 31dc480102fc by Martin Panter in branch 'default':
    Issue bpo-27369: Merge test_pyexpat from 3.5
    https://hg.python.org/cpython/rev/31dc480102fc

    @berkerpeksag berkerpeksag changed the title [PATCH] Tests break with --with-system-expat and Expat 2.2.0 Tests break with --with-system-expat and Expat 2.2.0 Jul 14, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @vadmium