Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible leaks in ctypes #71517

Closed
serhiy-storchaka opened this issue Jun 16, 2016 · 4 comments
Closed

Possible leaks in ctypes #71517

serhiy-storchaka opened this issue Jun 16, 2016 · 4 comments
Labels
extension-modules C modules in the Modules dir performance Performance or resource usage topic-ctypes

Comments

@serhiy-storchaka
Copy link
Member

BPO 27330
Nosy @amauryfa, @abalkin, @meadori, @vadmium, @serhiy-storchaka
Files
  • ctypes_leaks.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-06-17.08:36:06.406>
    created_at = <Date 2016-06-16.07:27:17.244>
    labels = ['extension-modules', 'ctypes', 'performance']
    title = 'Possible leaks in ctypes'
    updated_at = <Date 2016-06-17.08:36:06.404>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2016-06-17.08:36:06.404>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2016-06-17.08:36:06.406>
    closer = 'serhiy.storchaka'
    components = ['Extension Modules', 'ctypes']
    creation = <Date 2016-06-16.07:27:17.244>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['43406']
    hgrepos = []
    issue_num = 27330
    keywords = ['patch']
    message_count = 4.0
    messages = ['268646', '268660', '268688', '268714']
    nosy_count = 6.0
    nosy_names = ['amaury.forgeotdarc', 'belopolsky', 'meador.inge', 'python-dev', 'martin.panter', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'resource usage'
    url = 'https://bugs.python.org/issue27330'
    versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch fixes memory leaks in ctypes in case of errors.

    @serhiy-storchaka serhiy-storchaka added extension-modules C modules in the Modules dir topic-ctypes performance Performance or resource usage labels Jun 16, 2016
    @vadmium
    Copy link
    Member

    vadmium commented Jun 16, 2016

    Mostly looks good. I left a two comments.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 16, 2016

    New changeset e04c054beb53 by Serhiy Storchaka in branch '2.7':
    Issue bpo-27330: Fixed possible leaks in the ctypes module.
    https://hg.python.org/cpython/rev/e04c054beb53

    New changeset 41f99ee19804 by Serhiy Storchaka in branch '3.5':
    Issue bpo-27330: Fixed possible leaks in the ctypes module.
    https://hg.python.org/cpython/rev/41f99ee19804

    New changeset 27e7945c4ecd by Serhiy Storchaka in branch 'default':
    Issue bpo-27330: Fixed possible leaks in the ctypes module.
    https://hg.python.org/cpython/rev/27e7945c4ecd

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you for your review Martin! Committed with your fixes.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir performance Performance or resource usage topic-ctypes
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants