New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDLE: Fix deletion of custom themes and key bindings #71432
Comments
Open IDLE by running from console or importing idlelib.idle in interactive Python window. In the IDLE Preferences dialog, create a new custom theme or key set. [Apply] or close with [OK]. Reopen, if necessary, select the new custom set as current, select Delete, and Apply or close. IDLE will delete the set and then try to read it. A warning message will appear in the console/interpreter for each item in the set that is had to replace with the default value. IDLE should replace the deleted set with one of the builtins before reading, or even better, allow and require deletion of something that is not current. |
Proposed patch should fix this issue. |
New changeset 5c8cddc4a8ee by Terry Jan Reedy in branch '2.7': New changeset 438359d00a83 by Terry Jan Reedy in branch '3.5': New changeset 7948633608d5 by Terry Jan Reedy in branch 'default': |
New changeset 3ac9e7466d8b by Terry Jan Reedy in branch 'default': |
Patch amounts to putting 3 lines of apply inline and moving the first up to where is it needed. Serhiy, thanks for discovering the simple fix. It worked for me so I pushed it. I backported because the cascade of error messages is nasty when visible and because the forward merge was easy enough now that I know about the case clash problem. |
In bpo-4765, which I just closed as a duplicate, G Polo had same idea of applying change at top. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: