Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smtpd.__all__ list is incomplete #71297

Closed
Unit03 mannequin opened this issue May 24, 2016 · 6 comments
Closed

smtpd.__all__ list is incomplete #71297

Unit03 mannequin opened this issue May 24, 2016 · 6 comments
Labels
stdlib Python modules in the Lib dir topic-email type-feature A feature request or enhancement

Comments

@Unit03
Copy link
Mannequin

Unit03 mannequin commented May 24, 2016

BPO 27110
Nosy @warsaw, @bitdancer, @vadmium
Files
  • smtpd_all.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-06-06.02:55:48.665>
created_at = <Date 2016-05-24.20:41:47.686>
labels = ['type-feature', 'library', 'expert-email']
title = 'smtpd.__all__ list is incomplete'
updated_at = <Date 2016-06-06.02:55:48.664>
user = 'https://bugs.python.org/Unit03'

    bugs.python.org fields:

    activity = <Date 2016-06-06.02:55:48.664>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-06.02:55:48.665>
closer = 'martin.panter'
components = ['Library (Lib)', 'email']
creation = <Date 2016-05-24.20:41:47.686>
creator = 'Unit03'
dependencies = []
files = ['42977']
hgrepos = []
issue_num = 27110
keywords = ['patch']
message_count = 6.0
messages = ['266270', '266272', '266284', '266328', '266349', '267506']
nosy_count = 5.0
nosy_names = ['barry', 'r.david.murray', 'python-dev', 'martin.panter', 'Unit03']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27110'
versions = ['Python 3.6']
    @Unit03
    Copy link
    Mannequin Author

    Unit03 mannequin commented May 24, 2016

    That's a child issue of bpo-23883, created to propose a patch fixing smtpd module's __all__ list.

    @Unit03 Unit03 mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 24, 2016
    @bitdancer
    Copy link
    Member

    Maybe we should blacklist MailmanProxy? I think we are planning to deprecate it but just haven't yet done the work. Looks fine otherwise.

    @warsaw
    Copy link
    Member

    warsaw commented May 24, 2016

    On May 24, 2016, at 08:48 PM, R. David Murray wrote:

    Maybe we should blacklist MailmanProxy? I think we are planning to deprecate
    it but just haven't yet done the work. Looks fine otherwise.

    It's probably not used much TBH. aiosmtpd has a generic Proxy class.

    @vadmium
    Copy link
    Member

    vadmium commented May 25, 2016

    MailmanProxy is already included in __all__. Is there any advantage of removing it? Normally things are left in __all__ even when they actually get deprecated, as far as I understand.

    The patch looks sensible to me (though I am not very familiar with the module).

    @bitdancer
    Copy link
    Member

    Yeah, good point. Leave it alone.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 6, 2016

    New changeset bcc0c3fd4a40 by Martin Panter in branch 'default':
    Issue bpo-27110: Add smtpd.SMTPChannel to __all__, by Jacek Kołodziej
    https://hg.python.org/cpython/rev/bcc0c3fd4a40

    @vadmium vadmium closed this as completed Jun 6, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir topic-email type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @warsaw @bitdancer @vadmium