Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailbox.__all__ list is incomplete #71294

Closed
Unit03 mannequin opened this issue May 24, 2016 · 9 comments
Closed

mailbox.__all__ list is incomplete #71294

Unit03 mannequin opened this issue May 24, 2016 · 9 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@Unit03
Copy link
Mannequin

Unit03 mannequin commented May 24, 2016

BPO 27107
Nosy @bitdancer, @vadmium, @serhiy-storchaka
Files
  • mailbox_all.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-06-06.03:05:35.591>
created_at = <Date 2016-05-24.20:30:14.265>
labels = ['type-feature', 'library']
title = 'mailbox.__all__ list is incomplete'
updated_at = <Date 2016-06-06.03:05:35.589>
user = 'https://bugs.python.org/Unit03'

    bugs.python.org fields:

    activity = <Date 2016-06-06.03:05:35.589>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-06.03:05:35.591>
closer = 'martin.panter'
components = ['Library (Lib)']
creation = <Date 2016-05-24.20:30:14.265>
creator = 'Unit03'
dependencies = []
files = ['42969']
hgrepos = []
issue_num = 27107
keywords = ['patch']
message_count = 9.0
messages = ['266267', '266273', '266279', '266280', '266297', '266325', '267505', '267512', '267515']
nosy_count = 5.0
nosy_names = ['r.david.murray', 'python-dev', 'martin.panter', 'serhiy.storchaka', 'Unit03']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27107'
versions = ['Python 3.6']
    @Unit03
    Copy link
    Mannequin Author

    Unit03 mannequin commented May 24, 2016

    That's a child issue of bpo-23883, created to propose a patch fixing mailbox module's __all__ list.

    @Unit03 Unit03 mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 24, 2016
    @bitdancer
    Copy link
    Member

    Rather than adding the new class to the list of tests, we could take this opportunity to convert this test file to the new format, unless there's some reason that doesn't work (I don't expect there to be).

    @Unit03
    Copy link
    Mannequin Author

    Unit03 mannequin commented May 24, 2016

    David, what do you mean by "new format"? Can you point me to some existing code?

    @bitdancer
    Copy link
    Member

    Look at your mimetypes patch, for example. That if __name__='__main__' clause is all that is needed. The test_main stuff can be dropped.

    The question, I suppose, is the reap_children call, and that may be why it hasn't been converted yet.

    @serhiy-storchaka
    Copy link
    Member

    Yes, the reap_children call is the culprit. I think resolving this problem is out of the scope of this simple issue (there is separate issue for this).

    @vadmium
    Copy link
    Member

    vadmium commented May 25, 2016

    This patch looks good to me. I agree the reap_children() thing is a separate problem.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 6, 2016

    New changeset 4705b7597c86 by Martin Panter in branch 'default':
    Issue bpo-27107: Add exception classes to mailbox.__all__, by Jacek Kołodziej
    https://hg.python.org/cpython/rev/4705b7597c86

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 6, 2016

    New changeset d62e57958e7c by Martin Panter in branch 'default':
    Issue bpo-27107: mailbox.fcntl = None on Windows
    https://hg.python.org/cpython/rev/d62e57958e7c

    @vadmium
    Copy link
    Member

    vadmium commented Jun 6, 2016

    FTR the closest thing I could find discussing reap_children() is bpo-16968.

    @vadmium vadmium closed this as completed Jun 6, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @bitdancer @vadmium @serhiy-storchaka