Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated asynchat.fifo #71221

Closed
serhiy-storchaka opened this issue May 15, 2016 · 5 comments
Closed

Remove deprecated asynchat.fifo #71221

serhiy-storchaka opened this issue May 15, 2016 · 5 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 27034
Nosy @birkenfeld, @rhettinger, @josiahcarlson, @vstinner, @giampaolo, @ezio-melotti, @berkerpeksag, @serhiy-storchaka
Files
  • asynchat_remove_deprecated.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-05-16.06:37:28.101>
created_at = <Date 2016-05-15.19:32:54.025>
labels = ['type-feature', 'library']
title = 'Remove deprecated asynchat.fifo'
updated_at = <Date 2016-05-16.06:37:28.100>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2016-05-16.06:37:28.100>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2016-05-16.06:37:28.101>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2016-05-15.19:32:54.025>
creator = 'serhiy.storchaka'
dependencies = []
files = ['42866']
hgrepos = []
issue_num = 27034
keywords = ['patch']
message_count = 5.0
messages = ['265646', '265647', '265653', '265654', '265670']
nosy_count = 11.0
nosy_names = ['georg.brandl', 'rhettinger', 'josiahcarlson', 'vstinner', 'giampaolo.rodola', 'lehmannro', 'ezio.melotti', 'BreamoreBoy', 'python-dev', 'berker.peksag', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27034'
versions = ['Python 3.6']
    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch removes deprecated class fifo from the asynchat module and any remnants from the documentation. See also bpo-6916.

    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 15, 2016
    @giampaolo
    Copy link
    Contributor

    Looks good to me.

    @vstinner
    Copy link
    Member

    LGTM.

    @vstinner vstinner changed the title Remove derecated asynchat.fifo Remove deprecated asynchat.fifo May 15, 2016
    @vstinner
    Copy link
    Member

    The asynchat.fifo was deprecated in Python 3.5.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 16, 2016

    New changeset 2af26a93f87f by Serhiy Storchaka in branch 'default':
    Issue bpo-27034: Removed deprecated class asynchat.fifo.
    https://hg.python.org/cpython/rev/2af26a93f87f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @giampaolo @serhiy-storchaka