Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support of deprecated mode 'U' in zipfile #71216

Closed
serhiy-storchaka opened this issue May 15, 2016 · 4 comments
Closed

Remove support of deprecated mode 'U' in zipfile #71216

serhiy-storchaka opened this issue May 15, 2016 · 4 comments
Assignees
@serhiy-storchaka
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 27029
Nosy @Yhg1s, @serhiy-storchaka
Files
  • zipfile_remove_deprecated.patch
  • zipfile_remove_deprecated2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2016-06-11.16:37:20.486>
created_at = <Date 2016-05-15.18:23:22.853>
labels = ['type-feature', 'library']
title = "Remove support of deprecated mode 'U' in zipfile"
updated_at = <Date 2016-06-11.16:37:20.484>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2016-06-11.16:37:20.484>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2016-06-11.16:37:20.486>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2016-05-15.18:23:22.853>
creator = 'serhiy.storchaka'
dependencies = []
files = ['42861', '42958']
hgrepos = []
issue_num = 27029
keywords = ['patch']
message_count = 4.0
messages = ['265640', '266178', '268227', '268229']
nosy_count = 4.0
nosy_names = ['twouters', 'alanmcintyre', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27029'
versions = ['Python 3.6']
    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch removes support of modes 'U' and 'rU' in zipfile.ZipFile.open. This support was baggy and not consistent with other binary file objects. It was deprecated since Python 3.4.

    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 15, 2016
    @serhiy-storchaka
    Copy link
    Member Author

    Updated patch addresses Jim's comments.

    @serhiy-storchaka serhiy-storchaka self-assigned this Jun 11, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 11, 2016

    New changeset bf8773b054cb by Serhiy Storchaka in branch 'default':
    Issue bpo-27029: Removed deprecated support of universal newlines mode from ZipFile.open().
    https://hg.python.org/cpython/rev/bf8773b054cb

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you for your review Jim.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka