Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the 'is_android' attribute to test.support #71214

Closed
xdegaye mannequin opened this issue May 15, 2016 · 5 comments
Closed

add the 'is_android' attribute to test.support #71214

xdegaye mannequin opened this issue May 15, 2016 · 5 comments
Assignees
@xdegaye
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented May 15, 2016

BPO 27027
Nosy @pitrou, @vstinner, @ezio-melotti, @voidspace, @xdegaye
Files
  • is_android.patch
  • is_android_2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/xdegaye'
closed_at = <Date 2016-07-10.16:24:18.154>
created_at = <Date 2016-05-15.10:11:15.753>
labels = ['type-feature', 'tests']
title = "add the 'is_android' attribute to test.support"
updated_at = <Date 2016-07-10.16:24:18.154>
user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2016-07-10.16:24:18.154>
actor = 'xdegaye'
assignee = 'xdegaye'
closed = True
closed_date = <Date 2016-07-10.16:24:18.154>
closer = 'xdegaye'
components = ['Tests']
creation = <Date 2016-05-15.10:11:15.753>
creator = 'xdegaye'
dependencies = []
files = ['42910', '43667']
hgrepos = []
issue_num = 27027
keywords = ['needs review']
message_count = 5.0
messages = ['265609', '265915', '270035', '270085', '270098']
nosy_count = 6.0
nosy_names = ['pitrou', 'vstinner', 'ezio.melotti', 'michael.foord', 'xdegaye', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27027'
versions = ['Python 3.6']
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented May 15, 2016

    Needed by tests specific to Android or that must be skipped on Android.

    @xdegaye xdegaye mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels May 15, 2016
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented May 20, 2016

    The patch adds a dependency to issue bpo-26855.

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jul 9, 2016

    New patch using the changes made in bpo-27442.

    @xdegaye xdegaye mannequin changed the title add is_android in test.support to detect Android platform add the 'is_android' attribute to test.support Jul 9, 2016
    @xdegaye xdegaye mannequin self-assigned this Jul 9, 2016
    @vstinner
    Copy link
    Member

    LGTM. Go ahead.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 10, 2016

    New changeset 41dfd92f48f0 by Xavier de Gaye in branch 'default':
    Issue bpo-27027: Added test.support.is_android that is True when this is an
    https://hg.python.org/cpython/rev/41dfd92f48f0

    @xdegaye xdegaye mannequin closed this as completed Jul 10, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @xdegaye xdegaye

    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner