Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTTPS protocol in links #70923

Closed
serhiy-storchaka opened this issue Apr 11, 2016 · 6 comments
Closed

Use HTTPS protocol in links #70923

serhiy-storchaka opened this issue Apr 11, 2016 · 6 comments
Assignees
@serhiy-storchaka
Labels
docs Documentation in the Doc dir type-security A security issue

Comments

@serhiy-storchaka
Copy link
Member

BPO 26736
Nosy @birkenfeld, @pitrou, @vstinner, @giampaolo, @tiran, @tjguk, @alex, @serhiy-storchaka, @dstufft
Files
  • links_https.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2016-05-08.21:06:13.893>
created_at = <Date 2016-04-11.18:28:20.421>
labels = ['type-security', 'docs']
title = 'Use HTTPS protocol in links'
updated_at = <Date 2016-05-08.21:06:13.892>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2016-05-08.21:06:13.892>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2016-05-08.21:06:13.893>
closer = 'serhiy.storchaka'
components = ['Documentation']
creation = <Date 2016-04-11.18:28:20.421>
creator = 'serhiy.storchaka'
dependencies = []
files = ['42435']
hgrepos = []
issue_num = 26736
keywords = ['patch']
message_count = 6.0
messages = ['263197', '263225', '263228', '265047', '265048', '265054']
nosy_count = 12.0
nosy_names = ['georg.brandl', 'janssen', 'pitrou', 'vstinner', 'giampaolo.rodola', 'christian.heimes', 'tim.golden', 'alex', 'docs@python', 'python-dev', 'serhiy.storchaka', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'security'
url = 'https://bugs.python.org/issue26736'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch makes links in the docs to use the HTTPS protocol if possible. All changed links are tested manually.

    @serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir type-security A security issue labels Apr 11, 2016
    @birkenfeld
    Copy link
    Member

    +1

    @serhiy-storchaka
    Copy link
    Member Author

    If these changes are acceptable, we should change the :rfc:, :pep:, etc roles to produce links with https.

    I was not sure that these changes are worth, it was just interesting to me to research how many links support the HTTPS protocol now.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 7, 2016

    New changeset 211a9f32dfb9 by Serhiy Storchaka in branch '3.5':
    Issue bpo-26736: Used HTTPS for external links in the documentation if possible.
    https://hg.python.org/cpython/rev/211a9f32dfb9

    New changeset 3ceb54a49387 by Serhiy Storchaka in branch 'default':
    Issue bpo-26736: Used HTTPS for external links in the documentation if possible.
    https://hg.python.org/cpython/rev/3ceb54a49387

    New changeset e3af25d70976 by Serhiy Storchaka in branch '2.7':
    Issue bpo-26736: Used HTTPS for external links in the documentation if possible.
    https://hg.python.org/cpython/rev/e3af25d70976

    @serhiy-storchaka
    Copy link
    Member Author

    The :rfc: and :pep: roles are defined in Sphinx. I don't know if they can be configured to use HTTPS.

    @birkenfeld
    Copy link
    Member

    Newer Sphinx versions already redefine docutils' RFC and PEP URLs to use https.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    docs Documentation in the Doc dir type-security A security issue
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @birkenfeld @serhiy-storchaka