Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webbrowser.py doesn't properly handle BROWSER env var #46918

Closed
phdru mannequin opened this issue Apr 21, 2008 · 3 comments
Closed

webbrowser.py doesn't properly handle BROWSER env var #46918

phdru mannequin opened this issue Apr 21, 2008 · 3 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@phdru
Copy link
Mannequin

phdru mannequin commented Apr 21, 2008

BPO 2666
Nosy @birkenfeld, @phdru
Files
  • webbrowser.py.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2009-09-04.06:59:29.109>
created_at = <Date 2008-04-21.20:16:09.332>
labels = ['type-bug', 'library']
title = "webbrowser.py doesn't properly handle BROWSER env var"
updated_at = <Date 2009-09-04.06:59:29.107>
user = 'https://github.com/phdru'

    bugs.python.org fields:

    activity = <Date 2009-09-04.06:59:29.107>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = <Date 2009-09-04.06:59:29.109>
closer = 'georg.brandl'
components = ['Library (Lib)']
creation = <Date 2008-04-21.20:16:09.332>
creator = 'phd'
dependencies = []
files = ['12015']
hgrepos = []
issue_num = 2666
keywords = ['patch']
message_count = 3.0
messages = ['65665', '75914', '92235']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'phd']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2666'
versions = ['Python 2.5']
    @phdru
    Copy link
    Mannequin Author

    phdru mannequin commented Apr 21, 2008

    webbrowser.py ignores browsers listed in the BROWSER environment
    variables if it doesn't recognize the browser. For example, if I add
    "links2" to the BROWSER env var, webbrowser.py ignores it.

    It is because _synthesize() doesn't know how to handle an unknown
    browser. The attached patch checks if _synthesize() doesn't register a
    browser and registers a GenericBrowser.

    Another approach would be to register GenericBrowser in _synthesize().

    @phdru phdru mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Apr 21, 2008
    @phdru
    Copy link
    Mannequin Author

    phdru mannequin commented Nov 15, 2008

    Update the patch.

    @birkenfeld
    Copy link
    Member

    Thanks, applied in r74643.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @birkenfeld