Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows HUGE_VAL as extern variable #46914

Closed
ocean-city mannequin opened this issue Apr 20, 2008 · 4 comments
Closed

Allows HUGE_VAL as extern variable #46914

ocean-city mannequin opened this issue Apr 20, 2008 · 4 comments
Assignees
@mdickinson
Labels
extension-modules C modules in the Modules dir

Comments

@ocean-city
Copy link
Mannequin

ocean-city mannequin commented Apr 20, 2008

BPO 2662
Nosy @mdickinson
Files
  • cmathmodule.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/mdickinson'
closed_at = <Date 2008-04-20.16:14:25.203>
created_at = <Date 2008-04-20.13:30:46.839>
labels = ['extension-modules']
title = 'Allows HUGE_VAL as extern variable'
updated_at = <Date 2008-04-20.16:14:25.194>
user = 'https://bugs.python.org/ocean-city'

    bugs.python.org fields:

    activity = <Date 2008-04-20.16:14:25.194>
actor = 'mark.dickinson'
assignee = 'mark.dickinson'
closed = True
closed_date = <Date 2008-04-20.16:14:25.203>
closer = 'mark.dickinson'
components = ['Extension Modules']
creation = <Date 2008-04-20.13:30:46.839>
creator = 'ocean-city'
dependencies = []
files = ['10064']
hgrepos = []
issue_num = 2662
keywords = ['patch']
message_count = 4.0
messages = ['65646', '65647', '65648', '65649']
nosy_count = 2.0
nosy_names = ['mark.dickinson', 'ocean-city']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2662'
versions = ['Python 2.6']
    @ocean-city
    Copy link
    Mannequin Author

    ocean-city mannequin commented Apr 20, 2008

    /* On Windows HUGE_VAL is an extern variable and not a constant. Since the
    special value arrays need a constant we have to roll our own infinity
    and nan. */

    This patch removes this limitation.

    @ocean-city ocean-city mannequin added the extension-modules C modules in the Modules dir label Apr 20, 2008
    @mdickinson
    Copy link
    Member

    Sounds good.

    What patch? :-)

    @mdickinson
    Copy link
    Member

    Got it. Thanks. This may also fix the failure to build cmath on alpha
    Tru64.

    @mdickinson mdickinson self-assigned this Apr 20, 2008
    @mdickinson
    Copy link
    Member

    Applied in r62418.

    Thank you very much!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @mdickinson mdickinson

    Labels
    extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @mdickinson