Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiprocessing ThreadPool is untested #70710

Closed
pitrou opened this issue Mar 9, 2016 · 5 comments
Closed

multiprocessing ThreadPool is untested #70710

pitrou opened this issue Mar 9, 2016 · 5 comments
Assignees
@pitrou
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Mar 9, 2016

BPO 26523
Nosy @pitrou, @serhiy-storchaka, @applio
Files
  • test_threadpool.patch
  • test_threadpool2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pitrou'
closed_at = <Date 2016-03-15.09:56:34.813>
created_at = <Date 2016-03-09.20:37:10.248>
labels = ['tests', 'type-bug', 'library']
title = 'multiprocessing ThreadPool is untested'
updated_at = <Date 2016-03-15.09:56:34.812>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2016-03-15.09:56:34.812>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2016-03-15.09:56:34.813>
closer = 'pitrou'
components = ['Library (Lib)', 'Tests']
creation = <Date 2016-03-09.20:37:10.248>
creator = 'pitrou'
dependencies = []
files = ['42107', '42108']
hgrepos = []
issue_num = 26523
keywords = ['patch']
message_count = 5.0
messages = ['261474', '261476', '261484', '261804', '261807']
nosy_count = 7.0
nosy_names = ['pitrou', 'jnoller', 'neologix', 'python-dev', 'sbt', 'serhiy.storchaka', 'davin']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26523'
versions = ['Python 3.5', 'Python 3.6']
    @pitrou
    Copy link
    Member Author

    pitrou commented Mar 9, 2016

    There is a mistake in _test_multiprocessing.py which means that ThreadPool is untested, the regular Pool is tested instead by the ThreadsMixin. Patch attached.

    @pitrou pitrou added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Mar 9, 2016
    @pitrou
    Copy link
    Member Author

    pitrou commented Mar 9, 2016

    Turns out a couple of tests were calling multiprocessing.Pool directly, updating patch.

    @serhiy-storchaka
    Copy link
    Member

    LGTM.

    Is it worth to change multiprocessing.Pool in _TestPoolWorkerErrors and _TestPoolWorkerLifetime? Currently they work only for processes, but may be they can be generalized.

    @pitrou
    Copy link
    Member Author

    pitrou commented Mar 15, 2016

    Is it worth to change multiprocessing.Pool in _TestPoolWorkerErrors
    and _TestPoolWorkerLifetime? Currently they work only for processes,
    but may be they can be generalized.

    Perhaps as another issue? It may be more involved than this one.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 15, 2016

    New changeset 4cabf12b7fc6 by Antoine Pitrou in branch '3.5':
    Issue bpo-26523: The multiprocessing thread pool (multiprocessing.dummy.Pool) was untested.
    https://hg.python.org/cpython/rev/4cabf12b7fc6

    New changeset 131f92510164 by Antoine Pitrou in branch 'default':
    Issue bpo-26523: The multiprocessing thread pool (multiprocessing.dummy.Pool) was untested.
    https://hg.python.org/cpython/rev/131f92510164

    @pitrou pitrou closed this as completed Mar 15, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @pitrou pitrou

    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pitrou @serhiy-storchaka