Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors from msync ignored in mmap_object_dealloc #46896

Closed
schmir mannequin opened this issue Apr 16, 2008 · 5 comments
Closed

errors from msync ignored in mmap_object_dealloc #46896

schmir mannequin opened this issue Apr 16, 2008 · 5 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@schmir
Copy link
Mannequin

schmir mannequin commented Apr 16, 2008

BPO 2644
Nosy @briancurtin

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-01-17.20:20:56.519>
created_at = <Date 2008-04-16.16:30:25.258>
labels = ['type-bug']
title = 'errors from msync ignored in mmap_object_dealloc'
updated_at = <Date 2011-01-17.20:20:56.517>
user = 'https://bugs.python.org/schmir'

bugs.python.org fields:

activity = <Date 2011-01-17.20:20:56.517>
actor = 'brian.curtin'
assignee = 'none'
closed = True
closed_date = <Date 2011-01-17.20:20:56.519>
closer = 'brian.curtin'
components = []
creation = <Date 2008-04-16.16:30:25.258>
creator = 'schmir'
dependencies = []
files = []
hgrepos = []
issue_num = 2644
keywords = []
message_count = 5.0
messages = ['65553', '97573', '97583', '126414', '126433']
nosy_count = 3.0
nosy_names = ['schmir', 'brian.curtin', 'rosslagerwall']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2644'
versions = ['Python 2.6']
@schmir
Copy link
Mannequin Author

schmir mannequin commented Apr 16, 2008

mmapmodule.c's mmap_object_dealloc calls msync without checking for an
error.

@schmir schmir mannequin added the type-bug An unexpected behavior, bug, or error label Apr 16, 2008
@briancurtin
Copy link
Member

Do you have a test case to reproduce the errors?

I see that we call msync followed by munmap, neither one checked.

@schmir
Copy link
Mannequin Author

schmir mannequin commented Jan 11, 2010

No, I don't know how to provoke such an error other than passing illegal parameters..(or munmap'ing the mmap'ed area).

@rosslagerwall
Copy link
Mannequin

rosslagerwall mannequin commented Jan 17, 2011

I think this can be closed.

msync() is only called in mmap.flush() and it is checked for an error.

@briancurtin
Copy link
Member

That was changed in r84950 from bpo-2643.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briancurtin