Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeze.py makefile uses the wrong flags variables #70459

Closed
DanielShaulov mannequin opened this issue Feb 2, 2016 · 5 comments
Closed

freeze.py makefile uses the wrong flags variables #70459

DanielShaulov mannequin opened this issue Feb 2, 2016 · 5 comments
Assignees
@brettcannon
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@DanielShaulov
Copy link
Mannequin

DanielShaulov mannequin commented Feb 2, 2016

BPO 26271
Nosy @Yhg1s, @brettcannon, @moreati
Files
  • pyflags.patch: add PY_ to all FLAGS
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
closed_at = <Date 2016-03-18.17:31:03.175>
created_at = <Date 2016-02-02.23:02:15.737>
labels = ['type-bug', 'build']
title = 'freeze.py makefile uses the wrong flags variables'
updated_at = <Date 2016-03-18.17:31:03.174>
user = 'https://bugs.python.org/DanielShaulov'

    bugs.python.org fields:

    activity = <Date 2016-03-18.17:31:03.174>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2016-03-18.17:31:03.175>
closer = 'brett.cannon'
components = ['Build']
creation = <Date 2016-02-02.23:02:15.737>
creator = 'Daniel Shaulov'
dependencies = []
files = ['41785']
hgrepos = []
issue_num = 26271
keywords = ['patch']
message_count = 5.0
messages = ['259444', '261075', '261224', '261979', '261980']
nosy_count = 5.0
nosy_names = ['twouters', 'brett.cannon', 'python-dev', 'Alex.Willmer', 'Daniel Shaulov']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26271'
versions = ['Python 3.5', 'Python 3.6']
    @DanielShaulov
    Copy link
    Mannequin Author

    DanielShaulov mannequin commented Feb 2, 2016

    Tools/Freeze/makemakefile.py uses CFLAGS, LDFLAGS and CPPFLAGS instead of the PY_ prefixed versions. This makes flags passed to ./configure ineffective.

    The patch makes the trivial fix of adding PY_ when needed.

    @DanielShaulov DanielShaulov mannequin added build The build process and cross-build type-bug An unexpected behavior, bug, or error labels Feb 2, 2016
    @DanielShaulov
    Copy link
    Mannequin Author

    DanielShaulov mannequin commented Mar 1, 2016

    Pinging after a month without review (as the devguide suggests).

    @brettcannon
    Copy link
    Member

    Quick review suggests Daniel's patch does the right thing (based on Tools/freeze/test and looking at the generated Makefile which has PY_LDFLAGS defined).

    Don't have time to commit it right now, but I will in the near future.

    @brettcannon brettcannon self-assigned this Mar 5, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 18, 2016

    New changeset 599328247e84 by Brett Cannon in branch '3.5':
    Issue bpo-26271: Fix the Freeze tool to use variables passed in from the
    https://hg.python.org/cpython/rev/599328247e84

    New changeset 364895e54bb0 by Brett Cannon in branch 'default':
    Merge for issue bpo-26271
    https://hg.python.org/cpython/rev/364895e54bb0

    @brettcannon
    Copy link
    Member

    Thanks for the patch, Daniel! Added you to the ACKS file.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @brettcannon brettcannon

    Labels
    build The build process and cross-build type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @brettcannon