Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python.org installers to use OpenSSL 1.0.2f #70456

Closed
zware opened this issue Feb 2, 2016 · 5 comments
Closed

Update python.org installers to use OpenSSL 1.0.2f #70456

zware opened this issue Feb 2, 2016 · 5 comments
Labels
build The build process and cross-build OS-mac OS-windows type-security A security issue

Comments

@zware
Copy link
Member

zware commented Feb 2, 2016

BPO 26268
Nosy @pfmoore, @ronaldoussoren, @tjguk, @ned-deily, @zware, @zooba
PRs
  • [Security][3.4] bpo-29572: Update macOS installer build to OpenSSL 1.0.2k #3447
    		•
    Superseder
  • bpo-26465: Upgrade OpenSSL shipped with python installers
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-03-03.22:26:43.243>
created_at = <Date 2016-02-02.19:24:17.529>
labels = ['type-security', 'OS-mac', 'build', 'OS-windows']
title = 'Update python.org installers to use OpenSSL 1.0.2f'
updated_at = <Date 2017-09-08.02:35:36.690>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2017-09-08.02:35:36.690>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2016-03-03.22:26:43.243>
closer = 'steve.dower'
components = ['Build', 'macOS', 'Windows']
creation = <Date 2016-02-02.19:24:17.529>
creator = 'zach.ware'
dependencies = []
files = []
hgrepos = []
issue_num = 26268
keywords = []
message_count = 5.0
messages = ['259422', '260296', '260667', '260668', '261179']
nosy_count = 7.0
nosy_names = ['paul.moore', 'ronaldoussoren', 'tim.golden', 'ned.deily', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = ['3447']
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = '26465'
type = 'security'
url = 'https://bugs.python.org/issue26268'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    @zware
    Copy link
    Member Author

    zware commented Feb 2, 2016

    http://openssl.org/news/secadv/20160128.txt

    @zware zware added build The build process and cross-build OS-mac OS-windows labels Feb 2, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 15, 2016

    New changeset 1ceb431e1876 by Ned Deily in branch '2.7':
    Issue bpo-26268: Update OS X 10.5+ installer build to use OpenSSL 1.0.2f.
    https://hg.python.org/cpython/rev/1ceb431e1876

    New changeset 3c3eae72dd04 by Ned Deily in branch '3.5':
    Issue bpo-26268: Update OS X 10.5+ installer build to use OpenSSL 1.0.2f.
    https://hg.python.org/cpython/rev/3c3eae72dd04

    New changeset 6759581f9fd3 by Ned Deily in branch 'default':
    Issue bpo-26268: merge from 3.5
    https://hg.python.org/cpython/rev/6759581f9fd3

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 22, 2016

    New changeset 3be29e684ccf by Zachary Ware in branch '2.7':
    Issue bpo-26268: Update Windows builds to use OpenSSL 1.0.2f
    https://hg.python.org/cpython/rev/3be29e684ccf

    New changeset e1187d3204e9 by Zachary Ware in branch '3.5':
    Issue bpo-26268: Update the prepare_ssl.py script
    https://hg.python.org/cpython/rev/e1187d3204e9

    New changeset 82afdf5a8c7b by Zachary Ware in branch '3.5':
    Issue bpo-26268: Update Windows builds to use OpenSSL 1.0.2f
    https://hg.python.org/cpython/rev/82afdf5a8c7b

    New changeset 365ab6287783 by Zachary Ware in branch 'default':
    Issue bpo-26268: Merge with 3.5
    https://hg.python.org/cpython/rev/365ab6287783

    @zware
    Copy link
    Member Author

    zware commented Feb 22, 2016

    OpenSSL seems to have FUBARed their release process, such that the include/ directory no longer includes anything. As such I had to update prepare_ssl.py to handle creating include directories for 32 and 64 bit. This is somewhat wasteful since the only thing really different between the two is opensslconf.h, but this is the simplest approach.

    With that update, builds of 2.7 using the old project files in PC/VS9.0 now require Perl to be available to create the makefile. I don't think this is an undue burden; on the other hand, making prepare_ssl.py handle the requirements of the old build_ssl.py is far more effort than I want to invest.

    Steve, would you mind double-checking my work if you get a chance? I committed in a bit of a hurry at the request of Intel.

    @zware zware added the type-security A security issue label Feb 22, 2016
    @zooba
    Copy link
    Member

    zooba commented Mar 3, 2016

    Doesn't really matter, since we get to do it all again with bpo-26465.

    @zooba zooba closed this as completed Mar 3, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build OS-mac OS-windows type-security A security issue
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @zware