Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document BUILD_*_UNPACK opcodes #70401

Closed
brettcannon opened this issue Jan 26, 2016 · 8 comments
Closed

Document BUILD_*_UNPACK opcodes #70401

brettcannon opened this issue Jan 26, 2016 · 8 comments
Assignees
@brettcannon
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

BPO 26213
Nosy @Yhg1s, @brettcannon, @benjaminp, @berkerpeksag, @serhiy-storchaka, @NeilGirdhar, @ilevkivskyi
PRs
  • bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes #238
  • [3.6] bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes #440
  • [3.5] bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes #441
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
closed_at = <Date 2017-03-03.22:48:42.789>
created_at = <Date 2016-01-26.23:40:45.013>
labels = ['type-bug', '3.7', 'docs']
title = 'Document BUILD_*_UNPACK opcodes'
updated_at = <Date 2017-03-24.23:01:45.751>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2017-03-24.23:01:45.751>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2017-03-03.22:48:42.789>
closer = 'brett.cannon'
components = ['Documentation']
creation = <Date 2016-01-26.23:40:45.013>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 26213
keywords = []
message_count = 8.0
messages = ['258985', '258986', '268127', '287605', '288943', '290313', '290315', '290319']
nosy_count = 9.0
nosy_names = ['twouters', 'brett.cannon', 'benjamin.peterson', 'docs@python', 'berker.peksag', 'Joshua.Landau', 'serhiy.storchaka', 'NeilGirdhar', 'levkivskyi']
pr_nums = ['238', '440', '441']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26213'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']
    @brettcannon
    Copy link
    Member Author

    Turns out the BUILD_TUPLE_UNPACK and BUILD_LIST_UNPACK opcodes are undocumented in the dis module.

    @brettcannon brettcannon added the docs Documentation in the Doc dir label Jan 26, 2016
    @brettcannon
    Copy link
    Member Author

    There are also BUILD_SET_UNPACK and BUILD_MAP_UNPACK as well.

    @brettcannon brettcannon changed the title Document BUILD_LIST_UNPACK & BUILD_TUPLE_UNPACK Document BUILD_*_UNPACK opcodes Jan 26, 2016
    @serhiy-storchaka
    Copy link
    Member

    And BUILD_MAP_UNPACK_WITH_CALL.

    All these opcodes were added in bpo-2292 for implementing PEP-448, but are not documented even in the PEP.

    @serhiy-storchaka
    Copy link
    Member

    At the same time the semantic of the BUILD_MAP opcode was changed. However the documentation was not updated and currently it doesn't match the implementation. This caused an issue in third-party projects that operate with bytecode.

    See also bpo-28810 for documenting bytecode changes in 3.6.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error labels Feb 11, 2017
    @brettcannon brettcannon assigned brettcannon and unassigned docspython Mar 3, 2017
    @brettcannon
    Copy link
    Member Author

    Thanks to Ivan for the PRs!

    @brettcannon
    Copy link
    Member Author

    New changeset 4d0630d by Brett Cannon in branch '3.5':
    bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (GH-441)
    4d0630d

    @brettcannon
    Copy link
    Member Author

    New changeset 226af23 by Brett Cannon in branch '3.6':
    bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (GH-440)
    226af23

    @brettcannon
    Copy link
    Member Author

    New changeset 0705f66 by Brett Cannon (Ivan Levkivskyi) in branch 'master':
    bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (#238)
    0705f66

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @brettcannon brettcannon

    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @brettcannon @serhiy-storchaka