Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versionchanged note for error when create_module() is not defined by loaders #70372

Closed
brettcannon opened this issue Jan 22, 2016 · 8 comments
Closed

Add versionchanged note for error when create_module() is not defined by loaders #70372

brettcannon opened this issue Jan 22, 2016 · 8 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir easy type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

BPO 26184
Nosy @brettcannon, @ncoghlan, @ericsnowcurrently, @Carreau, @Mariatta
PRs
  • bpo-26184: import.rst: Add versionchanged note #277
  • [3.6] bpo-26184: import.rst: Improve versionchanged note (GH-277) #320
  • bpo-26184: import.rst: Improve versionchanged note #325
  • bpo-26184: import.rst: Improve versionchanged note (GH-325) #326
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-02-26.21:39:41.904>
created_at = <Date 2016-01-22.22:31:00.737>
labels = ['easy', 'type-bug', '3.7', 'docs']
title = 'Add versionchanged note for error when create_module() is not defined by loaders'
updated_at = <Date 2017-03-24.23:41:35.614>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2017-03-24.23:41:35.614>
actor = 'Mariatta'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-02-26.21:39:41.904>
closer = 'Mariatta'
components = ['Documentation']
creation = <Date 2016-01-22.22:31:00.737>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 26184
keywords = ['easy']
message_count = 8.0
messages = ['258840', '288502', '288505', '288614', '290373', '290374', '290381', '290386']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ncoghlan', 'docs@python', 'eric.snow', 'mbussonn', 'Mariatta']
pr_nums = ['277', '320', '325', '326']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26184'
versions = ['Python 3.6', 'Python 3.7']
    @brettcannon
    Copy link
    Member Author

    As explained in https://docs.python.org/3/reference/import.html#loaders, as of Python 3.6 an error is to be raised when a loader defines exec_module() but not create_module(). Probably should raise a TypeError.

    @brettcannon brettcannon added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Jan 22, 2016
    @Carreau
    Copy link
    Mannequin

    Carreau mannequin commented Feb 24, 2017

    should be closed by bpo-28026, it now raises an ImportError. I think this can be closed. Unless one want to change the text in Starting in Python 3.6 it will be an error

    Starting in Python 3.6 it will be an error

    To use the past tense.

    @ncoghlan
    Copy link
    Contributor

    That should actually be a versionchanged note now - converting this to an easy documentation issue to cover that change.

    @ncoghlan ncoghlan added 3.7 (EOL) end of life docs Documentation in the Doc dir easy and removed interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Feb 24, 2017
    @ncoghlan ncoghlan changed the title raise an error when create_module() is not defined by exec_module() is for loaders Add versionchanged note for error when create_module() is not defined by loaders Feb 24, 2017
    @Mariatta
    Copy link
    Member

    Merged and backported to 3.6.
    Closing this issue :)
    Thanks.

    @Mariatta
    Copy link
    Member

    New changeset 7e4897a by Mariatta in branch '3.6':
    bpo-26184: import.rst: Improve versionchanged note (GH-325) (GH-326)
    7e4897a

    @Mariatta
    Copy link
    Member

    New changeset 1f5639c by Mariatta in branch 'master':
    bpo-26184: import.rst: Improve versionchanged note (GH-325)
    1f5639c

    @Mariatta
    Copy link
    Member

    New changeset deea29e by Mariatta in branch '3.6':
    bpo-26184: import.rst: Improve versionchanged note (GH-277) (#320)
    deea29e

    @Mariatta
    Copy link
    Member

    New changeset 6b4a5f4 by Mariatta in branch 'master':
    bpo-26184: import.rst: Improve versionchanged note (GH-277)
    6b4a5f4

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir easy type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @brettcannon @ncoghlan @Mariatta