Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with Visual Studio 2015 using PlatformToolset=v120 #70267

Closed
bjoernthiel mannequin opened this issue Jan 11, 2016 · 9 comments
Closed

Build with Visual Studio 2015 using PlatformToolset=v120 #70267

bjoernthiel mannequin opened this issue Jan 11, 2016 · 9 comments
Assignees
@zooba
Labels
build The build process and cross-build OS-windows

Comments

@bjoernthiel
Copy link
Mannequin

bjoernthiel mannequin commented Jan 11, 2016

BPO 26079
Nosy @pfmoore, @tjguk, @zware, @zooba
Files
  • build.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2016-03-12.16:40:49.414>
created_at = <Date 2016-01-11.13:34:40.863>
labels = ['build', 'OS-windows']
title = 'Build with Visual Studio 2015 using PlatformToolset=v120'
updated_at = <Date 2016-03-12.16:40:49.413>
user = 'https://bugs.python.org/bjoernthiel'

    bugs.python.org fields:

    activity = <Date 2016-03-12.16:40:49.413>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2016-03-12.16:40:49.414>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2016-01-11.13:34:40.863>
creator = 'bjoernthiel'
dependencies = []
files = ['41578']
hgrepos = []
issue_num = 26079
keywords = ['patch']
message_count = 9.0
messages = ['257956', '257970', '257971', '257986', '257988', '259426', '259435', '261661', '261662']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower', 'bjoernthiel']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue26079'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    @bjoernthiel
    Copy link
    Mannequin Author

    bjoernthiel mannequin commented Jan 11, 2016

    Fixing the build output folder for tix-8.4.3.6.

    @bjoernthiel bjoernthiel mannequin added type-crash A hard crash of the interpreter, possibly with a core dump build The build process and cross-build labels Jan 11, 2016
    @SilentGhost SilentGhost mannequin added OS-windows build The build process and cross-build and removed type-crash A hard crash of the interpreter, possibly with a core dump labels Jan 11, 2016
    @zooba
    Copy link
    Member

    zooba commented Jan 11, 2016

    Good catch! Once I'm at a PC I'll merge this in unless someone else gets there first. (I believe it also applies to 2.7 since the project files were updated.)

    @zware
    Copy link
    Member

    zware commented Jan 11, 2016

    I'm on the fence about this one. MSVC 12.0 is not officially supported for any Python release. Also, using PlatformToolset makes things difficult for ICC builds (which set PlatformToolset to e.g. "Intel C++ Compiler 16.0").

    On the other hand, this is a very simple change, and building tkinter with ICC is pretty well completely broken anyway (it only works if you first build Tcl/Tk with MSVC).

    Call me +0; +1 if you can get around using PlatformToolset directly.

    @zooba
    Copy link
    Member

    zooba commented Jan 11, 2016

    It's better than using the Visual Studio version, which isn't necessarily tied to any VC version. To support another compiler will require more code like this anyway.

    An alternative may be to patch Tcl et al. to not put the VC version into the output path? That's likely to lead to different problems for people though...

    @zware
    Copy link
    Member

    zware commented Jan 11, 2016

    The fewer patches we carry against Tcl/Tk the better. This can be
    revisited if necessary when other ICC issues with our Tcl/Tk build are
    fixed.

    @zware
    Copy link
    Member

    zware commented Feb 2, 2016

    Perhaps the ideal approach here would be to pass TMP_DIR and OUT_DIR into the Tcl/Tk builds, so we can tell them where to put stuff. However, that would require major surgery to Tix's makefile to get it to build. I'd be +1 on doing so (since we're pretty much the de-facto maintainers of Tix at this point, as far as I can tell), but am not enthusiastic about actually doing it. I'd be much more enthusiastic about deprecating Tix.

    Steve, if the patch as given is good enough for you, I'm fine with applying it.

    @zooba
    Copy link
    Member

    zooba commented Feb 2, 2016

    Go ahead. Feel free to add toolsets to cover ICC if you need them.

    At one point I was passing through those directories for the build and it was not really trivial. A few too many places where it needed to be handled, but with patches against Tix it's probably disable.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 12, 2016

    New changeset 7617f5b3f263 by Steve Dower in branch '3.5':
    Issue bpo-26079: Fixing the build output folder for tix-8.4.3.6. Patch by Bjoern Thiel.
    https://hg.python.org/cpython/rev/7617f5b3f263

    New changeset f426178c9d6c by Steve Dower in branch 'default':
    Issue bpo-26079: Fixing the build output folder for tix-8.4.3.6. Patch by Bjoern Thiel.
    https://hg.python.org/cpython/rev/f426178c9d6c

    @zooba
    Copy link
    Member

    zooba commented Mar 12, 2016

    Python 2.7 has a different section in its tcltk.props file and doesn't need this fix (yet).

    Thanks for the patch, Bjoern!

    @zooba zooba closed this as completed Mar 12, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @zware