Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the list of magic numbers in launcher #70261

Closed
serhiy-storchaka opened this issue Jan 10, 2016 · 5 comments
Closed

Update the list of magic numbers in launcher #70261

serhiy-storchaka opened this issue Jan 10, 2016 · 5 comments
Assignees
@zooba
Labels
OS-windows type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 26073
Nosy @brettcannon, @pfmoore, @ncoghlan, @tjguk, @ericsnowcurrently, @zware, @serhiy-storchaka, @zooba
Files
  • launcher_magic_numbers.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2016-01-16.21:50:02.955>
created_at = <Date 2016-01-10.07:49:53.691>
labels = ['type-bug', 'OS-windows']
title = 'Update the list of magic numbers in launcher'
updated_at = <Date 2016-05-16.16:35:49.709>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2016-05-16.16:35:49.709>
actor = 'python-dev'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2016-01-16.21:50:02.955>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2016-01-10.07:49:53.691>
creator = 'serhiy.storchaka'
dependencies = []
files = ['41564']
hgrepos = []
issue_num = 26073
keywords = ['patch']
message_count = 5.0
messages = ['257896', '258421', '258422', '265447', '265710']
nosy_count = 9.0
nosy_names = ['brett.cannon', 'paul.moore', 'ncoghlan', 'tim.golden', 'python-dev', 'eric.snow', 'zach.ware', 'serhiy.storchaka', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26073'
versions = ['Python 3.5', 'Python 3.6']
    @serhiy-storchaka
    Copy link
    Member Author

    There is a list of magic numbers in PC/launcher.c for mapping magic number to Python version. But it ends on 3.3 (and even only on 3.3a0). Proposed patch updates the list (by values taken from Lib/importlib/_bootstrap_external.py).

    @serhiy-storchaka serhiy-storchaka added OS-windows type-bug An unexpected behavior, bug, or error labels Jan 10, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 16, 2016

    New changeset 1a2cfa52f749 by Steve Dower in branch '3.5':
    Issue bpo-26073: Update the list of magic numbers in launcher
    https://hg.python.org/cpython/rev/1a2cfa52f749

    New changeset cf868f77b400 by Steve Dower in branch 'default':
    Issue bpo-26073: Update the list of magic numbers in launcher
    https://hg.python.org/cpython/rev/cf868f77b400

    @zooba
    Copy link
    Member

    zooba commented Jan 16, 2016

    Thanks!

    @zooba zooba closed this as completed Jan 16, 2016
    @zooba zooba self-assigned this Jan 16, 2016
    @serhiy-storchaka
    Copy link
    Member Author

    Steve, could you please add a comment in Lib/importlib/_bootstrap_external.py about the need to update PC/launcher.c?

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 16, 2016

    New changeset d921932fe02f by Steve Dower in branch '3.5':
    Issue bpo-26073: Updates magic number comment in _bootstrap_external.py and changes numbers in launcher.py to decimal to match official table.
    https://hg.python.org/cpython/rev/d921932fe02f

    New changeset 0fe913de4702 by Steve Dower in branch 'default':
    Issue bpo-26073: Updates magic number comment in _bootstrap_external.py and changes numbers in launcher.py to decimal to match official table.
    https://hg.python.org/cpython/rev/0fe913de4702

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @serhiy-storchaka