Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Deprecated API in trace module #70257

Closed
orsenthil opened this issue Jan 10, 2016 · 11 comments
Closed

Remove the Deprecated API in trace module #70257

orsenthil opened this issue Jan 10, 2016 · 11 comments
Assignees
@orsenthil
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@orsenthil
Copy link
Member

BPO 26069
Nosy @abalkin, @orsenthil, @berkerpeksag, @Vgr255
Files
  • issue26069.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
closed_at = <Date 2016-01-11.15:11:47.916>
created_at = <Date 2016-01-10.00:20:26.857>
labels = ['type-bug', 'library']
title = 'Remove the Deprecated API in trace module'
updated_at = <Date 2016-01-18.04:12:25.237>
user = 'https://github.com/orsenthil'

    bugs.python.org fields:

    activity = <Date 2016-01-18.04:12:25.237>
actor = 'python-dev'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2016-01-11.15:11:47.916>
closer = 'orsenthil'
components = ['Library (Lib)']
creation = <Date 2016-01-10.00:20:26.857>
creator = 'orsenthil'
dependencies = []
files = ['41562']
hgrepos = []
issue_num = 26069
keywords = ['patch']
message_count = 11.0
messages = ['257877', '257881', '257883', '257884', '257965', '257966', '257967', '257968', '258174', '258446', '258497']
nosy_count = 5.0
nosy_names = ['belopolsky', 'orsenthil', 'python-dev', 'berker.peksag', 'abarry']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26069'
versions = ['Python 3.6']
    @orsenthil
    Copy link
    Member Author

    A number of old methods in trace module were deprecated in bpo-10371. They should be removed in 3.6 release.

    @orsenthil orsenthil added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Jan 10, 2016
    @orsenthil
    Copy link
    Member Author

    This patch removes the deprecated apis from 3.6. After getting a review from one another core dev, I will commit this.

    • No doc changes are required as the deprecated apis were not documented.
    • README will be added during commit.

    @orsenthil orsenthil self-assigned this Jan 10, 2016
    @Vgr255
    Copy link
    Mannequin

    Vgr255 mannequin commented Jan 10, 2016

    You seem to have forgotten to include a patch.

    @orsenthil
    Copy link
    Member Author

    Sorry for that. Here is the patch.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 11, 2016

    New changeset 6f05bdc18661 by Senthil Kumaran in branch 'default':
    Issue bpo-26069: Remove the deprecated apis in the trace module.
    https://hg.python.org/cpython/rev/6f05bdc18661

    @orsenthil
    Copy link
    Member Author

    Thanks for the review, matrixise. I've submitted this change.

    @berkerpeksag
    Copy link
    Member

    I couldn't find exact references, but I think we've reached an agreement that we want to keep old APIs in the stdlib to make porting from Python 2 easier. So you might want to revert this :)

    @orsenthil
    Copy link
    Member Author

    Hi Berker, could you find the reference for it? It will be helpful to analyze.
    IMO, the non-removal of 2.x-> 3.x APIs could be done on a case to case basis.

    In this case, bpo-10371 made the change in (2010) of making the undocumented public methods to private internal and deprecated those old undocumented internal (but public) methods. It was a correct thing to do. Removal of the deprecated should have been done sooner. Otherwise, we are left with redundant methods (public and _private) in the same module serving no useful purpose.

    @berkerpeksag
    Copy link
    Member

    Sorry, I don't have much time investigate this further, but here is a few references from my bookmarks:

    Another discussions about deprecation policy: bpo-24203 (old threading API), bpo-25486 (inspect.getargspec()) and bpo-26041 (platform.dist() and platform.linux_distribution())

    If you want to keep the old API removed, it would be great to add a note in Doc/whatsnew/3.6.rst in addtion to the Misc/NEWS entry.

    @orsenthil
    Copy link
    Member Author

    Thanks for the pointers, Berker. That was very helpful and I will keep in mind when evaluating other deprecated apis.

    For the trace module, I will add this removal information in Doc/whatsnew/3.6.rst

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 18, 2016

    New changeset 715d8a739f3b by Senthil Kumaran in branch 'default':
    bpo-26069 - Update whatsnew/3.6.rst on traceback module's api removals.
    https://hg.python.org/cpython/rev/715d8a739f3b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @orsenthil orsenthil

    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @orsenthil