Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lib2to3 grammar to include missing unpacking generalizations. #70157

Closed
ezio-melotti opened this issue Dec 28, 2015 · 5 comments
Closed

Update lib2to3 grammar to include missing unpacking generalizations. #70157

ezio-melotti opened this issue Dec 28, 2015 · 5 comments
Assignees
@gpshead
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@ezio-melotti
Copy link
Member

BPO 25969
Nosy @gpshead, @benjaminp, @ezio-melotti, @1st1, @zhangyangyu
Files
  • issue25969-gps01.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
closed_at = <Date 2016-09-10.01:34:28.710>
created_at = <Date 2015-12-28.22:16:18.963>
labels = ['type-bug', 'library']
title = 'Update lib2to3 grammar to include missing unpacking generalizations.'
updated_at = <Date 2016-09-10.18:21:34.042>
user = 'https://github.com/ezio-melotti'

    bugs.python.org fields:

    activity = <Date 2016-09-10.18:21:34.042>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2016-09-10.01:34:28.710>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2015-12-28.22:16:18.963>
creator = 'ezio.melotti'
dependencies = []
files = ['44518']
hgrepos = []
issue_num = 25969
keywords = ['patch']
message_count = 5.0
messages = ['257138', '275526', '275531', '275654', '275666']
nosy_count = 6.0
nosy_names = ['gregory.p.smith', 'benjamin.peterson', 'ezio.melotti', 'python-dev', 'yselivanov', 'xiang.zhang']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25969'
versions = ['Python 2.7']
    @ezio-melotti
    Copy link
    Member Author

    The new unpacking generalizations added in bpo-2292 should be added to the lib2to3 grammar (see msg248019 and msg248025).

    See also bpo-25967.

    @ezio-melotti ezio-melotti added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Dec 28, 2015
    @gpshead gpshead self-assigned this Sep 9, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 10, 2016

    New changeset 1206c64de875 by Gregory P. Smith in branch '3.5':
    Issue bpo-25969: Update the lib2to3 grammar to handle the unpacking
    https://hg.python.org/cpython/rev/1206c64de875

    New changeset 2460b30c1985 by Gregory P. Smith in branch 'default':
    Issue bpo-25969: Update the lib2to3 grammar to handle the unpacking
    https://hg.python.org/cpython/rev/2460b30c1985

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 10, 2016

    New changeset 8344cf7eebf8 by Gregory P. Smith in branch '2.7':
    Issue bpo-25969: Update the lib2to3 grammar to handle the unpacking
    https://hg.python.org/cpython/rev/8344cf7eebf8

    @gpshead gpshead closed this as completed Sep 10, 2016
    @zhangyangyu
    Copy link
    Member

    Gregory, the change adds a print in: https://hg.python.org/cpython/file/tip/Lib/lib2to3/fixes/fix_reload.py#l29

    ./python -m test test_lib2to3
    Run tests sequentially
    0:00:00 [1/1] test_lib2to3
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Node(star_expr, [Leaf(16, '*'), Leaf(1, 'h')])
    obj: Node(argument, [Leaf(36, '**'), Leaf(1, 'i')])
    1 test OK.

    Total duration: 12 sec
    Tests result: SUCCESS

    @gpshead
    Copy link
    Member

    gpshead commented Sep 10, 2016

    Haha whoops, that'd be my debugging. I'll remove it this weekend if nobody
    else has gotten to it.

    On Sat, Sep 10, 2016, 9:44 AM Xiang Zhang <report@bugs.python.org> wrote:

    Xiang Zhang added the comment:

    Gregory, the change adds a print in:
    https://hg.python.org/cpython/file/tip/Lib/lib2to3/fixes/fix_reload.py#l29

    ./python -m test test_lib2to3
    Run tests sequentially
    0:00:00 [1/1] test_lib2to3
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Leaf(1, 'a')
    obj: Node(star_expr, [Leaf(16, '*'), Leaf(1, 'h')])
    obj: Node(argument, [Leaf(36, '**'), Leaf(1, 'i')])
    1 test OK.

    Total duration: 12 sec
    Tests result: SUCCESS

    ----------
    nosy: +xiang.zhang

    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue25969\>

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gpshead gpshead

    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gpshead @zhangyangyu @ezio-melotti