New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ICC in configure #70013
Comments
Attached is a patch that adds support for ICC to configure, making it easier to build with ICC on Unix and adjusting arguments to better fit ICC.
Be sure to run autoreconf before testing. |
This patch looks correct to me, but I don't have much experience with configure. Are the .dyn files icc's profiling output? I'm adding Alecsandru and Brett as nosy since they worked on the PGO stuff. I'm also adding Stefan since he's shown interest in icc. |
Thank you David for including me in this issue. On ICC, when executing the instrumented applications, it will generate dynamic information file that has a unique name and .dyn suffix. From my previous experience with GCC and CLANG PGO patch (bpo-24915), also the output of the autoconf will have to be included in the final diff. Regarding the place for adding the '-fp-model strict' flags, I had the same dillema when working on the LTO patch (bpo-25702), because I needed the flags to be propagated to _all_ compilation and linking phases, and finally decided to add them to the CONFIGURE_CFLAGS, CONFIGURE_CFLAGS_NODIST, CONFIGURE_CPPFLAGS, CONFIGURE_LDFLAGS variables in the Makefile.pre.in file. You can try there also and keep the BASECFLAGS clean . |
After testing, I think I like '-fp-model strict' better in CFLAGS_NODIST. On Ubuntu, On the other hand, 2.7 doesn't have CFLAGS_NODIST (and I don't want to add it), so BASECFLAGS is about the only option there. Barring objections, I'll commit this new patch in a few days. |
New changeset d7b5c2f99a99 by Zachary Ware in branch '2.7': New changeset c5e419464585 by Zachary Ware in branch '3.5': New changeset 29ea3827cfaa by Zachary Ware in branch 'default': |
The buildbots appear to be happy with this, so I'm closing the issue. The intel-ubuntu-icc Non-Debug builders each had their first green build after this changeset. The OSX ICC builder still has some issues, but they seem to be OSX specific (see bpo-25589). |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: