Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't change the framework name on OS X builds #46825

Closed
habnabit mannequin opened this issue Apr 7, 2008 · 7 comments
Closed

Can't change the framework name on OS X builds #46825

habnabit mannequin opened this issue Apr 7, 2008 · 7 comments
Assignees
@ronaldoussoren
Labels
build The build process and cross-build OS-mac type-feature A feature request or enhancement

Comments

@habnabit
Copy link
Mannequin

habnabit mannequin commented Apr 7, 2008

BPO 2573
Nosy @ronaldoussoren, @benjaminp
Files
  • framework.patch: svn diff output
  • framework2.patch: patch, take two
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ronaldoussoren'
closed_at = <Date 2008-05-02.20:27:29.099>
created_at = <Date 2008-04-07.19:47:23.855>
labels = ['OS-mac', 'type-feature', 'build']
title = "Can't change the framework name on OS X builds"
updated_at = <Date 2008-05-02.20:27:29.098>
user = 'https://bugs.python.org/habnabit'

    bugs.python.org fields:

    activity = <Date 2008-05-02.20:27:29.098>
actor = 'benjamin.peterson'
assignee = 'ronaldoussoren'
closed = True
closed_date = <Date 2008-05-02.20:27:29.099>
closer = 'benjamin.peterson'
components = ['Build', 'macOS']
creation = <Date 2008-04-07.19:47:23.855>
creator = 'habnabit'
dependencies = []
files = ['9977', '9979']
hgrepos = []
issue_num = 2573
keywords = ['patch']
message_count = 7.0
messages = ['65105', '65123', '65136', '65147', '65149', '65781', '66107']
nosy_count = 3.0
nosy_names = ['ronaldoussoren', 'benjamin.peterson', 'habnabit']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue2573'
versions = ['Python 2.6', 'Python 3.0']
    @habnabit
    Copy link
    Mannequin Author

    habnabit mannequin commented Apr 7, 2008

    There is currently no way in the configure script to specify an
    alternate name for Python.framework. If I want to completely separate
    versions of Python (e.g. for 3.0 alphas and/or Stackless), I have to
    manually edit configure.in and configure to change the framework name.
    It would be much more convenient if --with-framework could take an
    optional parameter of the framework name to use.

    @habnabit habnabit mannequin added build The build process and cross-build OS-mac type-feature A feature request or enhancement labels Apr 7, 2008
    @benjaminp
    Copy link
    Contributor

    Would you like to work on a patch?

    @habnabit
    Copy link
    Mannequin Author

    habnabit mannequin commented Apr 8, 2008

    Here's a framework that implements the necessary change. I'm not very good
    at autoconf, so it might need to be touched up.

    @ronaldoussoren
    Copy link
    Contributor

    To start: thanks for the patch.

    I haven't done a detailed review yet, I have a minor nit: could you
    change Mac/Makefile.in as well, specifically the definition:

    PYTHONAPPSDIR=/Applications/MacPython $(VERSION)

    This is used to install a number of GUI applications. "MacPython" should
    be replaced by the framework name. That will drop the "Mac" prefix in a
    default install, but that's not a problem and possibly confusing anyway.

    @habnabit
    Copy link
    Mannequin Author

    habnabit mannequin commented Apr 8, 2008

    Okay, here's the same patch but now with Mac/Makefile.in patched. I
    changed all references to Python to the framework name, because I believe
    it won't work properly otherwise.

    @ronaldoussoren
    Copy link
    Contributor

    The new patch looks great. I'll apply it next week.

    @ronaldoussoren
    Copy link
    Contributor

    This functionality is enabled as of revision 62644

    The actual patch is slightly more involved than the attached patches,
    the patch forgot to add a variable to Mac/Makefile.in and doesn't patch
    Mac/IDLE/Makefile.in at all.

    I've also made the Info.plist inside applications and the framework
    dynamic (that is, patched by configure), that way the Python version is
    automaticly patched into these files.

    Furthermore the framework identifier is changed when you use the --with-
    framework-name argument to configure.

    There is one minor open issue with this patch, which I won't fix:
    site.py adds ~/Library/Python/... to sys.path, but only if
    "Python.framework" is in sys.prefix. That code won't trigger when
    building a framework with another name (such as --with-framework-
    name=Stackless). I don't think that can be fixed without modifying
    site.py during configure or installation. (see site.py, line 199)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ronaldoussoren ronaldoussoren

    Labels
    build The build process and cross-build OS-mac type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @ronaldoussoren