Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.5.1 installer shows wrong upgrade path #69901

Closed
zooba opened this issue Nov 23, 2015 · 8 comments
Closed

Python 3.5.1 installer shows wrong upgrade path #69901

zooba opened this issue Nov 23, 2015 · 8 comments
Assignees
@zooba
Labels
OS-windows release-blocker topic-installation type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Nov 23, 2015

BPO 25715
Nosy @pfmoore, @larryhastings, @tjguk, @zware, @zooba
Files
  • 25715_1.patch
  • 25715_2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2015-12-06.00:42:13.891>
created_at = <Date 2015-11-23.20:24:42.641>
labels = ['type-bug', 'expert-installation', 'OS-windows', 'release-blocker']
title = 'Python 3.5.1 installer shows wrong upgrade path'
updated_at = <Date 2015-12-06.00:42:13.889>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2015-12-06.00:42:13.889>
actor = 'larry'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-12-06.00:42:13.891>
closer = 'larry'
components = ['Installation', 'Windows']
creation = <Date 2015-11-23.20:24:42.641>
creator = 'steve.dower'
dependencies = []
files = ['41152', '41166']
hgrepos = []
issue_num = 25715
keywords = ['patch', '3.5regression']
message_count = 8.0
messages = ['255219', '255282', '255294', '255392', '255706', '255734', '255735', '255993']
nosy_count = 6.0
nosy_names = ['paul.moore', 'larry', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25715'
versions = ['Python 3.5', 'Python 3.6']
    @zooba
    Copy link
    Member Author

    zooba commented Nov 23, 2015

    When launching the installer to upgrade from a Python 3.5.0 install to 3.5.1, the path shown on the Install button is incorrect. Clicking the button installs to the correct location.

    This is a regression from 3.5.0 that will cause a lot of confusion. It ought to be fixed.

    @zooba zooba self-assigned this Nov 23, 2015
    @zooba zooba added topic-installation OS-windows type-bug An unexpected behavior, bug, or error labels Nov 23, 2015
    @zooba
    Copy link
    Member Author

    zooba commented Nov 24, 2015

    Fix attached:

    • moves the UI update to the correct time (after we've detected the path)
    • fixes a launcher detection issue I noticed
    • removes a duplicated function

    @zooba
    Copy link
    Member Author

    zooba commented Nov 24, 2015

    Launcher detection still isn't quite right - another patch coming.

    @zooba
    Copy link
    Member Author

    zooba commented Nov 25, 2015

    Man, dealing with the launcher is hard. But I've got it about as good as I can:

    • when installing 3.5.1 over 3.5.0, user has the option to update/not update the launcher (no option to uninstall at that time)
    • after installing 3.5.1, launcher can be added via Modify, but not removed - the checkbox is now disabled with this change
    • with 3.5.1, the launcher has its own entry in Programs and Features (from a different bug)
    • uninstalling 3.5.1 does not automatically uninstall the launcher

    This patch updates the help text in the installer to better explain what's going on, and now gets the "requires admin" icon correct.

    Larry - this change is fully contained to the installer and (along with the original part of the issue above) should avoid a lot of confusion once we release. Can I have it in 3.5.1? I'm happy to rebase and push directly to your repo.

    @larryhastings
    Copy link
    Contributor

    You can have it in 3.5.1, and we can negotiate about how to get it in.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 2, 2015

    New changeset 8537ec50c254 by Steve Dower in branch '3.5':
    Issue bpo-25715: Python 3.5.1 installer shows wrong upgrade path and incorrect logic for launcher detection.
    https://hg.python.org/cpython/rev/8537ec50c254

    @zooba
    Copy link
    Member Author

    zooba commented Dec 2, 2015

    As you can see, I've now pushed to the main 3.5 branch, so feel free to cherry-pick from there or give me the word and I'll graft it into the releasing repo for you.

    I also forward merged all the 3.5.1 NEWS into default. Not sure how that normally happens, but it was easier to do it with a big copy-past than try and figure out the merge conflicts...

    @larryhastings
    Copy link
    Contributor

    Fixed in 3.5.1 final.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows release-blocker topic-installation type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @larryhastings