Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract OrderedDict tests into separate file #69802

Closed
serhiy-storchaka opened this issue Nov 13, 2015 · 5 comments
Closed

Extract OrderedDict tests into separate file #69802

serhiy-storchaka opened this issue Nov 13, 2015 · 5 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 25616
Nosy @rhettinger, @ericsnowcurrently, @serhiy-storchaka
Files
  • test_ordered_dict.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-11-25.15:20:37.566>
created_at = <Date 2015-11-13.13:01:21.526>
labels = ['type-feature', 'tests']
title = 'Extract OrderedDict tests into separate file'
updated_at = <Date 2015-11-25.15:20:38.596>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2015-11-25.15:20:38.596>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-11-25.15:20:37.566>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2015-11-13.13:01:21.526>
creator = 'serhiy.storchaka'
dependencies = []
files = ['41056']
hgrepos = []
issue_num = 25616
keywords = ['patch']
message_count = 5.0
messages = ['254602', '254618', '254697', '254732', '255363']
nosy_count = 4.0
nosy_names = ['rhettinger', 'python-dev', 'eric.snow', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25616'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']
    @serhiy-storchaka
    Copy link
    Member Author

    OrderedDict tests now are about 1/3 of test_collections, and I think their volume will grow. I suggest to extract these tests into separate file test_ordereddict. There are precedences: test_deque (deque also is implemented in C), and test_userdict, test_userlist and test_userstring (for historical reasons).

    The main reason to me is the possibility to run quick OrderedDict tests (and only OrderedDict tests).

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Nov 13, 2015
    @ericsnowcurrently
    Copy link
    Member

    FWIW, I totally support this. I originally had a patch up that did so but Raymond indicated that he'd rather not split the tests out though I made exactly the same arguments that you have. Perhaps he's changed his mind in the intervening years (or I misunderstood his objections)? :)

    @rhettinger
    Copy link
    Contributor

    If it helps with all the great work you're doing, go ahead and move the OD tests out to a separate file.

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you Raymond. Here is a patch. It is in Git format, hence Rietveld will not work with it. During creating a patch I found a bug in test_dict_update, it tested only default implementation and didn't test subclasses.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 25, 2015

    New changeset 8d9a0540adf9 by Serhiy Storchaka in branch '3.4':
    Issue bpo-25616: Tests for OrderedDict are extracted from test_collections
    https://hg.python.org/cpython/rev/8d9a0540adf9

    New changeset 46e95e0eaae5 by Serhiy Storchaka in branch '3.5':
    Issue bpo-25616: Tests for OrderedDict are extracted from test_collections
    https://hg.python.org/cpython/rev/46e95e0eaae5

    New changeset 81fa901162f9 by Serhiy Storchaka in branch 'default':
    Issue bpo-25616: Tests for OrderedDict are extracted from test_collections
    https://hg.python.org/cpython/rev/81fa901162f9

    New changeset afaad8dc8edf by Serhiy Storchaka in branch '2.7':
    Issue bpo-25616: Tests for OrderedDict are extracted from test_collections
    https://hg.python.org/cpython/rev/afaad8dc8edf

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ericsnowcurrently @rhettinger @serhiy-storchaka