Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: OP_NO_SSLv3 should always be set unless a user specifically asks for it #69716

Closed
alex opened this issue Nov 1, 2015 · 3 comments
Closed

ssl: OP_NO_SSLv3 should always be set unless a user specifically asks for it #69716

alex opened this issue Nov 1, 2015 · 3 comments
Labels
stdlib Python modules in the Lib dir

Comments

@alex
Copy link
Member

alex commented Nov 1, 2015

BPO 25530
Nosy @pitrou, @giampaolo, @tiran, @alex, @dstufft
Files
  • sslv3.diff
  • sslv3.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-11-12.06:45:50.140>
created_at = <Date 2015-11-01.19:10:53.961>
labels = ['library']
title = 'ssl: OP_NO_SSLv3 should always be set unless a user specifically asks for it'
updated_at = <Date 2015-11-12.06:45:50.138>
user = 'https://github.com/alex'

    bugs.python.org fields:

    activity = <Date 2015-11-12.06:45:50.138>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-11-12.06:45:50.140>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2015-11-01.19:10:53.961>
creator = 'alex'
dependencies = []
files = ['40920', '40927']
hgrepos = []
issue_num = 25530
keywords = ['patch', 'needs review', 'security_issue']
message_count = 3.0
messages = ['253868', '253907', '254520']
nosy_count = 7.0
nosy_names = ['janssen', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'alex', 'python-dev', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue25530'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    @alex
    Copy link
    Member Author

    alex commented Nov 1, 2015

    SSLv3 is broken, both _create_unverified_context and create_default_context turn it off, but we should make all contexts turn it off, like we do for SSLv2.

    A patch is attached.

    @alex alex added the stdlib Python modules in the Lib dir label Nov 1, 2015
    @alex
    Copy link
    Member Author

    alex commented Nov 2, 2015

    Oops, there were a few failing tests on that patch. New one is green

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 12, 2015

    New changeset d80954d941c7 by Benjamin Peterson in branch '2.7':
    always set OP_NO_SSLv3 by default (closes bpo-25530)
    https://hg.python.org/cpython/rev/d80954d941c7

    New changeset 56f64ec9259f by Benjamin Peterson in branch '3.4':
    always set OP_NO_SSLv3 by default (closes bpo-25530)
    https://hg.python.org/cpython/rev/56f64ec9259f

    New changeset d1737db0f1b2 by Benjamin Peterson in branch '3.5':
    merge 3.4 (bpo-25530)
    https://hg.python.org/cpython/rev/d1737db0f1b2

    New changeset 2899acbd2b46 by Benjamin Peterson in branch 'default':
    merge 3.5 (bpo-25530)
    https://hg.python.org/cpython/rev/2899acbd2b46

    @python-dev python-dev mannequin closed this as completed Nov 12, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @alex