Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite test_robotparser #69683

Closed
berkerpeksag opened this issue Oct 28, 2015 · 2 comments
Closed

Rewrite test_robotparser #69683

berkerpeksag opened this issue Oct 28, 2015 · 2 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@berkerpeksag
Copy link
Member

BPO 25497
Nosy @berkerpeksag
PRs
  • [2.7] bpo-30759: Copy test_robotparser from master #2546
    		•
    Files
  • test_robotparser.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-09-11.11:53:10.455>
created_at = <Date 2015-10-28.14:05:50.678>
labels = ['type-feature', 'tests']
title = 'Rewrite test_robotparser'
updated_at = <Date 2017-07-04.04:54:54.667>
user = 'https://github.com/berkerpeksag'

    bugs.python.org fields:

    activity = <Date 2017-07-04.04:54:54.667>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2016-09-11.11:53:10.455>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2015-10-28.14:05:50.678>
creator = 'berker.peksag'
dependencies = []
files = ['40875']
hgrepos = []
issue_num = 25497
keywords = ['patch']
message_count = 2.0
messages = ['253599', '275774']
nosy_count = 2.0
nosy_names = ['python-dev', 'berker.peksag']
pr_nums = ['2546']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25497'
versions = ['Python 3.6']
    @berkerpeksag
    Copy link
    Member Author

    The attached patch rewrites test_robotparser to use a class based approach.

    Other changes:

    • Added support.reap_threads to PasswordProtectedSiteTestCase
    • Reenabled testPythonOrg since the python.org problem has already been fixed

    @berkerpeksag berkerpeksag added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Oct 28, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 11, 2016

    New changeset 2193bd6f020c by Berker Peksag in branch 'default':
    Issue bpo-25497: Rewrite test_robotparser to use a class based design
    https://hg.python.org/cpython/rev/2193bd6f020c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @berkerpeksag