Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect inspect.getargspec() in 3.6 #69672

Closed
1st1 opened this issue Oct 26, 2015 · 11 comments
Closed

Resurrect inspect.getargspec() in 3.6 #69672

1st1 opened this issue Oct 26, 2015 · 11 comments
Labels
release-blocker stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@1st1
Copy link
Member

1st1 commented Oct 26, 2015

BPO 25486
Nosy @rhettinger, @nedbat, @skrah, @berkerpeksag, @vadmium, @1st1, @jayvdb

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-01-11.20:17:11.589>
created_at = <Date 2015-10-26.20:33:43.829>
labels = ['type-bug', 'library', 'release-blocker']
title = 'Resurrect inspect.getargspec() in 3.6'
updated_at = <Date 2016-01-12.02:05:33.910>
user = 'https://github.com/1st1'

bugs.python.org fields:

activity = <Date 2016-01-12.02:05:33.910>
actor = 'yselivanov'
assignee = 'none'
closed = True
closed_date = <Date 2016-01-11.20:17:11.589>
closer = 'yselivanov'
components = ['Library (Lib)']
creation = <Date 2015-10-26.20:33:43.829>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 25486
keywords = []
message_count = 11.0
messages = ['253499', '257842', '257843', '257844', '257845', '258006', '258007', '258008', '258051', '258055', '258056']
nosy_count = 8.0
nosy_names = ['rhettinger', 'nedbat', 'skrah', 'python-dev', 'berker.peksag', 'martin.panter', 'yselivanov', 'jayvdb']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25486'
versions = ['Python 3.6']

@1st1
Copy link
Member Author

1st1 commented Oct 26, 2015

See issue bpo-20438 for more details

@1st1 1st1 added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Oct 26, 2015
@skrah
Copy link
Mannequin

skrah mannequin commented Jan 9, 2016

Could this be done soon? I ran into this just now:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/stefan/usr/lib/python3.6/site-packages/datashape-0.4.7-py3.6.egg/datashape/__init__.py", line 7, in <module>
    from .user import *
  File "/home/stefan/usr/lib/python3.6/site-packages/datashape-0.4.7-py3.6.egg/datashape/user.py", line 16, in <module>
    @dispatch(np.dtype, basetypes)
  File "/home/stefan/usr/lib/python3.6/site-packages/multipledispatch-0.4.8-py3.6.egg/multipledispatch/core.py", line 60, in _
    if ismethod(func):
  File "/home/stefan/usr/lib/python3.6/site-packages/multipledispatch-0.4.8-py3.6.egg/multipledispatch/core.py", line 79, in ismethod
    spec = inspect.getargspec(func)
AttributeError: module 'inspect' has no attribute 'getargspec'

@skrah skrah mannequin added the release-blocker label Jan 9, 2016
@berkerpeksag
Copy link
Member

Perhaps we can also add it back in 3.5.2 since 3.5 is in early stages of its maintenance period?

@skrah
Copy link
Mannequin

skrah mannequin commented Jan 9, 2016

+1 for adding it to 3.5.2.

@1st1
Copy link
Member Author

1st1 commented Jan 9, 2016

Perhaps we can also add it back in 3.5.2 since 3.5 is in early stages of its maintenance period?

+1 for adding it to 3.5.2.

I was never removed from 3.5

    Python 3.5.1 (default, Dec 13 2015, 16:05:52)
    [GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import inspect
    >>> inspect.getargspec
    <function getargspec at 0x104811048

@python-dev
Copy link
Mannequin

python-dev mannequin commented Jan 11, 2016

New changeset 32c8bdcd66cc by Yury Selivanov in branch 'default':
Issue bpo-25486: Resurrect inspect.getargspec in 3.6. Backout a565aad5d6e1.
https://hg.python.org/cpython/rev/32c8bdcd66cc

@1st1
Copy link
Member Author

1st1 commented Jan 11, 2016

inspect.getargspec is back to Python 3.6 (it was never removed from <= 3.5, fwiw)

@1st1 1st1 closed this as completed Jan 11, 2016
@skrah
Copy link
Mannequin

skrah mannequin commented Jan 11, 2016

On Mon, Jan 11, 2016 at 08:17:11PM +0000, Yury Selivanov wrote:

inspect.getargspec is back to Python 3.6 (it was never removed from <= 3.5, fwiw)

Yay! Thank you very much!

@vadmium
Copy link
Member

vadmium commented Jan 12, 2016

Now the documentation says it will be removed in 3.6. I guess the 3.5 documentation also needs updating.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Jan 12, 2016

New changeset 36a54e30bcbd by Yury Selivanov in branch '3.5':
Issue bpo-25486: Drop "removed in 3.6" wording from inspect.getargspec docs.
https://hg.python.org/cpython/rev/36a54e30bcbd

New changeset 4f1a0e5deca6 by Yury Selivanov in branch 'default':
Merge 3.5 (issue bpo-25486)
https://hg.python.org/cpython/rev/4f1a0e5deca6

@1st1
Copy link
Member Author

1st1 commented Jan 12, 2016

Now the documentation says it will be removed in 3.6. I guess the 3.5 documentation also needs updating.

Good catch!

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants