Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep lock type when reseting internal locks #69506

Closed
nirs mannequin opened this issue Oct 5, 2015 · 2 comments
Closed

Keep lock type when reseting internal locks #69506

nirs mannequin opened this issue Oct 5, 2015 · 2 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@nirs
Copy link
Mannequin

nirs mannequin commented Oct 5, 2015

BPO 25319
Nosy @gpshead, @nirs
Files
  • 0001-Keep-lock-type-when-reseting-internal-locks.patch: Fix for master
  • 0001-Keep-lock-type-when-reseting-internal-locks-2.7.patch: Patch for 2.7
  • 0001-Keep-lock-type-when-reseting-internal-locks.patch: Cleaner version of master patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-10-06.05:01:40.014>
    created_at = <Date 2015-10-05.13:23:23.636>
    labels = ['type-bug', 'library']
    title = 'Keep lock type when reseting internal locks'
    updated_at = <Date 2015-10-06.05:01:40.012>
    user = 'https://github.com/nirs'

    bugs.python.org fields:

    activity = <Date 2015-10-06.05:01:40.012>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2015-10-06.05:01:40.014>
    closer = 'python-dev'
    components = ['Library (Lib)']
    creation = <Date 2015-10-05.13:23:23.636>
    creator = 'nirs'
    dependencies = []
    files = ['40686', '40687', '40688']
    hgrepos = []
    issue_num = 25319
    keywords = ['patch']
    message_count = 2.0
    messages = ['252326', '252376']
    nosy_count = 3.0
    nosy_names = ['gregory.p.smith', 'nirs', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue25319'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

    @nirs
    Copy link
    Mannequin Author

    nirs mannequin commented Oct 5, 2015

    When Event._reset_internal_locks was called after fork, it use to
    reinitialize its condition without arguments, using RLock instead of
    Lock.

    @nirs nirs mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Oct 5, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 6, 2015

    New changeset 69a26f0800b3 by Benjamin Peterson in branch '2.7':
    reinitialize an Event's Condition with a regular lock (closes bpo-25319)
    https://hg.python.org/cpython/rev/69a26f0800b3

    New changeset 6108d30dde21 by Benjamin Peterson in branch '3.4':
    reinitialize an Event's Condition with a regular lock (closes bpo-25319)
    https://hg.python.org/cpython/rev/6108d30dde21

    New changeset 3719e842a7b1 by Benjamin Peterson in branch '3.5':
    merge 3.4 (bpo-25319)
    https://hg.python.org/cpython/rev/3719e842a7b1

    New changeset 41f29bbf520d by Benjamin Peterson in branch 'default':
    merge 3.5 (bpo-25319)
    https://hg.python.org/cpython/rev/41f29bbf520d

    @python-dev python-dev mannequin closed this as completed Oct 6, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants