Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unneeded and unsafe mkstemp replacement in test_subprocess.py #69436

Closed
nirs mannequin opened this issue Sep 27, 2015 · 4 comments
Closed

Unneeded and unsafe mkstemp replacement in test_subprocess.py #69436

nirs mannequin opened this issue Sep 27, 2015 · 4 comments
Labels
tests Tests in the Lib/test dir

Comments

@nirs
Copy link
Mannequin

nirs mannequin commented Sep 27, 2015

BPO 25249
Nosy @nirs, @berkerpeksag
Files
  • 0001-Remove-unneeded-and-unsafe-mkstemp-replacement.patch: Patch fixing this issue
  • 0001-Remove-unneeded-and-unsafe-mkstemp-replacement-2.7.patch: Patch for 2.7
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-09-28.12:39:18.721>
created_at = <Date 2015-09-27.19:40:34.450>
labels = ['tests']
title = 'Unneeded and unsafe mkstemp replacement in test_subprocess.py'
updated_at = <Date 2015-09-28.12:39:18.718>
user = 'https://github.com/nirs'

    bugs.python.org fields:

    activity = <Date 2015-09-28.12:39:18.718>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2015-09-28.12:39:18.721>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2015-09-27.19:40:34.450>
creator = 'nirs'
dependencies = []
files = ['40599', '40601']
hgrepos = []
issue_num = 25249
keywords = ['patch']
message_count = 4.0
messages = ['251720', '251757', '251761', '251762']
nosy_count = 3.0
nosy_names = ['nirs', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue25249'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']
    @nirs
    Copy link
    Mannequin Author

    nirs mannequin commented Sep 27, 2015

    The module define unsafe replacement if tempfile.mkstemp is not available.

    This function is available in both master and 2.7 branches.

    @nirs nirs mannequin added the tests Tests in the Lib/test dir label Sep 27, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 28, 2015

    New changeset 23f4daf7a211 by Berker Peksag in branch '3.4':
    Issue bpo-25249: Remove unneeded mkstemp helper in test_subprocess
    https://hg.python.org/cpython/rev/23f4daf7a211

    New changeset 4cd3027ffc34 by Berker Peksag in branch '3.5':
    Issue bpo-25249: Remove unneeded mkstemp helper in test_subprocess
    https://hg.python.org/cpython/rev/4cd3027ffc34

    New changeset e863c8760501 by Berker Peksag in branch 'default':
    Issue bpo-25249: Remove unneeded mkstemp helper in test_subprocess
    https://hg.python.org/cpython/rev/e863c8760501

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 28, 2015

    New changeset ea91991c7db5 by Berker Peksag in branch '2.7':
    Issue bpo-25249: Remove unneeded mkstemp helper in test_subprocess
    https://hg.python.org/cpython/rev/ea91991c7db5

    @berkerpeksag
    Copy link
    Member

    Thanks for the patch, Nir. Just fixed a small typo(fd -> f) in the 2.7 patch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @berkerpeksag