Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows uninstallation should not remove launcher if other versions remain #69352

Closed
chrullrich mannequin opened this issue Sep 18, 2015 · 3 comments
Closed

Windows uninstallation should not remove launcher if other versions remain #69352

chrullrich mannequin opened this issue Sep 18, 2015 · 3 comments
Assignees
@zooba
Labels
OS-windows topic-installation type-bug An unexpected behavior, bug, or error

Comments

@chrullrich
Copy link
Mannequin

chrullrich mannequin commented Sep 18, 2015

BPO 25165
Nosy @pfmoore, @tjguk, @zware, @zooba, @chrullrich

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2015-10-01.22:21:01.841>
created_at = <Date 2015-09-18.09:03:04.029>
labels = ['type-bug', 'expert-installation', 'OS-windows']
title = 'Windows uninstallation should not remove launcher if other versions remain'
updated_at = <Date 2015-10-01.22:21:01.840>
user = 'https://github.com/chrullrich'

bugs.python.org fields:

activity = <Date 2015-10-01.22:21:01.840>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-10-01.22:21:01.841>
closer = 'steve.dower'
components = ['Installation', 'Windows']
creation = <Date 2015-09-18.09:03:04.029>
creator = 'chrullrich'
dependencies = []
files = []
hgrepos = []
issue_num = 25165
keywords = []
message_count = 3.0
messages = ['250957', '251377', '252068']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower', 'chrullrich']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25165'
versions = ['Python 3.5']
@chrullrich
Copy link
Mannequin Author

chrullrich mannequin commented Sep 18, 2015

Uninstalling 3.5 on Windows removes the py.exe launcher. If it was installed in the system-wide path (%SYSTEMROOT%), it may have replaced an existing copy from an earlier version. In this case, removing the launcher will break this remaining installation, requiring a repair.

Instead, the launcher should not be deleted. It uses the static CRT, hence has no DLL dependencies that would be removed by the uninstallation, and it will -- as PEP-397 demands -- select the Python version it starts based on the command line and the available installations.

Ceterum censeo: This bug could have been avoided by using MSI as the distribution package format and using the same component code for the launcher file in all supporting versions. Even if the file itself is different, the identical component code would have ensured through reference counting that it would only have been removed with the last referencing installation. Upward compatibility of older launchers could have become a problem, though.

@chrullrich chrullrich mannequin added topic-installation OS-windows type-bug An unexpected behavior, bug, or error labels Sep 18, 2015
@zooba
Copy link
Member

zooba commented Sep 23, 2015

I'm going to look into having the launcher's MSI stay behind when the bundle is removed, so it will have to be uninstalled separately. It can already be installed separately, though there isn't a really easy way to get the installer so you can do that.

(Because prior versions of Python did not always use the same component ID for the launcher, we have to have a break here. However, we now have a single MSI that is identical for all future versions, so the problem should not arise again.)

@zooba zooba self-assigned this Sep 23, 2015
@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 1, 2015

New changeset a2d30dfa46a7 by Steve Dower in branch '3.5':
Issue bpo-25165: Windows uninstallation should not remove launcher if other versions remain
https://hg.python.org/cpython/rev/a2d30dfa46a7

@zooba zooba closed this as completed Oct 1, 2015
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
OS-windows topic-installation type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zooba