Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows installer in AllUsers mode presents wrong installation path #69350

Closed
chrullrich mannequin opened this issue Sep 18, 2015 · 3 comments
Closed

Windows installer in AllUsers mode presents wrong installation path #69350

chrullrich mannequin opened this issue Sep 18, 2015 · 3 comments
Assignees
@zooba
Labels
OS-windows topic-installation type-bug An unexpected behavior, bug, or error

Comments

@chrullrich
Copy link
Mannequin

chrullrich mannequin commented Sep 18, 2015

BPO 25163
Nosy @pfmoore, @tjguk, @zware, @zooba, @chrullrich

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2015-10-11.22:38:15.116>
created_at = <Date 2015-09-18.08:13:20.208>
labels = ['type-bug', 'expert-installation', 'OS-windows']
title = 'Windows installer in AllUsers mode presents wrong installation path'
updated_at = <Date 2015-10-11.22:38:15.115>
user = 'https://github.com/chrullrich'

bugs.python.org fields:

activity = <Date 2015-10-11.22:38:15.115>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-10-11.22:38:15.116>
closer = 'steve.dower'
components = ['Installation', 'Windows']
creation = <Date 2015-09-18.08:13:20.208>
creator = 'chrullrich'
dependencies = []
files = []
hgrepos = []
issue_num = 25163
keywords = []
message_count = 3.0
messages = ['250955', '251381', '252827']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower', 'chrullrich']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25163'
versions = ['Python 3.5']
@chrullrich
Copy link
Mannequin Author

chrullrich mannequin commented Sep 18, 2015

When run with InstallAllUsers=1, the Windows installer displays (%LOCALAPPDATA%)\Programs\Python\Python35 as the installation target directory, but actually installs into the path for a system-wide installation, "%PROGRAMFILES%\Python 3.5".

Ceterum censeo: This bug could have been avoided, and would certainly have been detected in time, by using MSI as the distribution package format. Because most MSI UI will display TARGETDIR as the target directory, an accidental override (or missing override) of this path would have been obvious.

@chrullrich chrullrich mannequin added topic-installation OS-windows type-bug An unexpected behavior, bug, or error labels Sep 18, 2015
@zooba
Copy link
Member

zooba commented Sep 23, 2015

Just an incorrect variable reference in the localization file. Should be easy enough to fix (if the variable is initialized at the start of installation...)

@zooba zooba self-assigned this Sep 23, 2015
@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 11, 2015

New changeset 919b1dffa741 by Steve Dower in branch '3.5':
Issue bpo-25163: Display correct directory in installer when using non-default settings.
https://hg.python.org/cpython/rev/919b1dffa741

New changeset 6f97c51b6dc5 by Steve Dower in branch 'default':
Issue bpo-25163: Display correct directory in installer when using non-default settings.
https://hg.python.org/cpython/rev/6f97c51b6dc5

@zooba zooba closed this as completed Oct 11, 2015
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
OS-windows topic-installation type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zooba