Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows installer requires TargetDir parameter when installing quietly #69258

Closed
zooba opened this issue Sep 11, 2015 · 6 comments
Closed

Windows installer requires TargetDir parameter when installing quietly #69258

zooba opened this issue Sep 11, 2015 · 6 comments
Assignees
@zooba
Labels
OS-windows topic-installation type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Sep 11, 2015

BPO 25071
Nosy @pfmoore, @larryhastings, @tjguk, @takluyver, @zware, @zooba
Files
  • 25071_1.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2015-09-11.18:32:09.779>
created_at = <Date 2015-09-11.16:10:01.104>
labels = ['type-bug', 'expert-installation', 'OS-windows']
title = 'Windows installer requires TargetDir parameter when installing quietly'
updated_at = <Date 2015-09-11.18:32:09.778>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2015-09-11.18:32:09.778>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-09-11.18:32:09.779>
closer = 'steve.dower'
components = ['Installation', 'Windows']
creation = <Date 2015-09-11.16:10:01.104>
creator = 'steve.dower'
dependencies = []
files = ['40439']
hgrepos = []
issue_num = 25071
keywords = ['patch']
message_count = 6.0
messages = ['250476', '250477', '250480', '250486', '250487', '250488']
nosy_count = 7.0
nosy_names = ['paul.moore', 'larry', 'tim.golden', 'python-dev', 'takluyver', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25071'
versions = ['Python 3.5', 'Python 3.6']
    @zooba
    Copy link
    Member Author

    zooba commented Sep 11, 2015

    If you run the installer without UI and without specifying an installation path, it will not install. For example:

    C:\> python-3.5.0rc4-amd64-webinstall.exe /passive

    The workaround is to specify TargetPath:

    C:\> python-3.5.0rc4-amd64-webinstall.exe /passive TargetPath="C:\Python35_x64"

    However, this workaround should not be necessary. We should use the default path based on the InstallAllUsers setting (false by default).

    @zooba zooba self-assigned this Sep 11, 2015
    @zooba zooba added topic-installation OS-windows type-bug An unexpected behavior, bug, or error labels Sep 11, 2015
    @zooba
    Copy link
    Member Author

    zooba commented Sep 11, 2015

    Adding Larry, as this either needs a fix or a prominent release note for 3.5.0 (or we document the bug in the docs).

    I *think* the fix will be fairly simple and constrained entire to one file. Should have something ready later today.

    @zooba
    Copy link
    Member Author

    zooba commented Sep 11, 2015

    Patch attached.

    PR for 3.5.0 at: https://bitbucket.org/larry/cpython350/pull-requests/25/issue-25071-windows-installer-should-not/diff

    @larryhastings
    Copy link
    Contributor

    Pull request approved. Hopefully the last one for 3.5.0! Please forward-merge.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 11, 2015

    New changeset da8f2767b6cc by Steve Dower in branch '3.5':
    Issue bpo-25071: Windows installer should not require TargetDir parameter when installing quietly
    https://hg.python.org/cpython/rev/da8f2767b6cc

    New changeset bb7363b8b50e by Steve Dower in branch 'default':
    Issue bpo-25071: Windows installer should not require TargetDir parameter when installing quietly
    https://hg.python.org/cpython/rev/bb7363b8b50e

    @zooba
    Copy link
    Member Author

    zooba commented Sep 11, 2015

    I hope so too :)

    @zooba zooba closed this as completed Sep 11, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows topic-installation type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @larryhastings