Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be possible to build successfully without external libraries #69174

Closed
zware opened this issue Sep 2, 2015 · 5 comments
Closed

It should be possible to build successfully without external libraries #69174

zware opened this issue Sep 2, 2015 · 5 comments
Assignees
@zware
Labels
build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error

Comments

@zware
Copy link
Member

zware commented Sep 2, 2015

BPO 24986
Nosy @pfmoore, @tjguk, @zware, @zooba
Files
  • 2.7_external_build_handling.diff
  • 3.5_external_build_handling.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zware'
closed_at = <Date 2015-09-04.04:56:19.449>
created_at = <Date 2015-09-02.20:30:29.880>
labels = ['type-bug', 'OS-windows', 'build']
title = 'It should be possible to build successfully without external libraries'
updated_at = <Date 2015-09-04.06:14:48.183>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2015-09-04.06:14:48.183>
actor = 'python-dev'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2015-09-04.04:56:19.449>
closer = 'python-dev'
components = ['Build', 'Windows']
creation = <Date 2015-09-02.20:30:29.880>
creator = 'zach.ware'
dependencies = []
files = ['40322', '40323']
hgrepos = []
issue_num = 24986
keywords = ['patch']
message_count = 5.0
messages = ['249567', '249568', '249712', '249713', '249719']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24986'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    @zware
    Copy link
    Member Author

    zware commented Sep 2, 2015

    We do have the option of leaving out all extension modules ("/p:IncludeExtensions=false"), but it would be nice to be able to build everything that doesn't require external libs.

    This also be adds an option to skip only Tkinter (analogous to "/p:IncludeSSL=false"), as that's what I actually need at the moment :). I'm not adding options for every external project individually, as most of them are not a big deal, but OpenSSL, Tcl/Tk/Tix, and (on 2.7) bsddb take a long time to compile and might be nice to leave out when they're not needed (so I also added the ability to leave out bsddb on 2.7).

    Leaving out 3.4 as its project files are not amenable to this kind of change, and 3.4's days are numbered anyway.

    @zware zware self-assigned this Sep 2, 2015
    @zware zware added build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error labels Sep 2, 2015
    @zware
    Copy link
    Member Author

    zware commented Sep 2, 2015

    This also changes the behavior of the '-e' flag on build.bat a bit, leaving off '-e' means there will be no attempt to build the modules that require external sources even if the sources are already there. Adding '-e' means building those modules will be attempted, subject to the '--no-<module>' flags.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 4, 2015

    New changeset 2bc91f1f2b34 by Zachary Ware in branch '2.7':
    Issue bpo-24986: Allow building Python without external libraries on Windows
    https://hg.python.org/cpython/rev/2bc91f1f2b34

    New changeset 301c36746e42 by Zachary Ware in branch '3.5':
    Issue bpo-24986: Allow building Python without external libraries on Windows
    https://hg.python.org/cpython/rev/301c36746e42

    New changeset 50d38fa13282 by Zachary Ware in branch 'default':
    Closes bpo-24986: Merge with 3.5
    https://hg.python.org/cpython/rev/50d38fa13282

    @python-dev python-dev mannequin closed this as completed Sep 4, 2015
    @zware
    Copy link
    Member Author

    zware commented Sep 4, 2015

    The committed versions are slightly different, I had bad logic in adding _socket to ExtensionModules (if IncludeExternals was false while IncludeSSL was true, _socket wasn't added). build.bat also uses the property names instead of its own internal names so as not to stomp on the environment.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 4, 2015

    New changeset 252d4760f28b by Zachary Ware in branch '2.7':
    Issue bpo-24986: Save some bandwidth from svn.python.org
    https://hg.python.org/cpython/rev/252d4760f28b

    New changeset 4e7ce0b10eea by Zachary Ware in branch '3.5':
    Issue bpo-24986: Save some bandwidth from svn.python.org
    https://hg.python.org/cpython/rev/4e7ce0b10eea

    New changeset eca6ecc62b95 by Zachary Ware in branch 'default':
    Issue bpo-24986: Merge with 3.5
    https://hg.python.org/cpython/rev/eca6ecc62b95

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zware zware

    Labels
    build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zware