Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method reopenFile() in WatchedFileHandler class #69072

Closed
MarianHorban mannequin opened this issue Aug 18, 2015 · 2 comments
Closed

Add method reopenFile() in WatchedFileHandler class #69072

MarianHorban mannequin opened this issue Aug 18, 2015 · 2 comments
Labels
type-feature A feature request or enhancement

Comments

@MarianHorban
Copy link
Mannequin

MarianHorban mannequin commented Aug 18, 2015

BPO 24884
Nosy @vsajip
Files
  • add_reopen_file.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-10-01.19:55:03.323>
created_at = <Date 2015-08-18.09:36:54.672>
labels = ['type-feature']
title = 'Add method reopenFile() in WatchedFileHandler class'
updated_at = <Date 2015-10-01.19:55:03.320>
user = 'https://bugs.python.org/MarianHorban'

    bugs.python.org fields:

    activity = <Date 2015-10-01.19:55:03.320>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-10-01.19:55:03.323>
closer = 'python-dev'
components = []
creation = <Date 2015-08-18.09:36:54.672>
creator = 'Marian Horban'
dependencies = []
files = ['40201']
hgrepos = []
issue_num = 24884
keywords = ['patch']
message_count = 2.0
messages = ['248765', '252048']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'python-dev', 'Marian Horban']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24884'
versions = []
    @MarianHorban
    Copy link
    Mannequin Author

    MarianHorban mannequin commented Aug 18, 2015

    Method WatchedFileHandler::emit() makes 2 things:

    1. reopens log file,
    2. emits record.
      Sometimes user wants to reopen file immediately after some action without emitting.
      Code that reopens file must be moved to separate method to avoid copy-pasting code in programs that use this functionality.
      Patch is provided.

    @MarianHorban MarianHorban mannequin added the type-feature A feature request or enhancement label Aug 18, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 1, 2015

    New changeset 6d61b057c375 by Vinay Sajip in branch 'default':
    Closes bpo-24884: refactored WatchedFileHandler file reopening into a separate method, based on a suggestion and patch by Marian Horban.
    https://hg.python.org/cpython/rev/6d61b057c375

    @python-dev python-dev mannequin closed this as completed Oct 1, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    0 participants