Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual margin indicator for breakpoints in IDLE #69013

Closed
roseman mannequin opened this issue Aug 7, 2015 · 4 comments
Closed

visual margin indicator for breakpoints in IDLE #69013

roseman mannequin opened this issue Aug 7, 2015 · 4 comments
Labels
topic-IDLE type-feature A feature request or enhancement

Comments

@roseman
Copy link
Mannequin

roseman mannequin commented Aug 7, 2015

BPO 24825
Nosy @terryjreedy, @kbkaiser, @serwy, @roseman
Superseder
  • bpo-17535: IDLE editor line numbers
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-08-07.23:10:33.706>
    created_at = <Date 2015-08-07.14:16:34.792>
    labels = ['expert-IDLE', 'type-feature']
    title = 'visual margin indicator for breakpoints in IDLE'
    updated_at = <Date 2015-08-07.23:10:33.705>
    user = 'https://github.com/roseman'

    bugs.python.org fields:

    activity = <Date 2015-08-07.23:10:33.705>
    actor = 'terry.reedy'
    assignee = 'none'
    closed = True
    closed_date = <Date 2015-08-07.23:10:33.706>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2015-08-07.14:16:34.792>
    creator = 'markroseman'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 24825
    keywords = []
    message_count = 4.0
    messages = ['248194', '248223', '248226', '248234']
    nosy_count = 4.0
    nosy_names = ['terry.reedy', 'kbk', 'roger.serwy', 'markroseman']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '17535'
    type = 'enhancement'
    url = 'https://bugs.python.org/issue24825'
    versions = ['Python 3.5', 'Python 3.6']

    @roseman
    Copy link
    Mannequin Author

    roseman mannequin commented Aug 7, 2015

    Right now breakpoints can only be set/cleared by using a context menu on a line in the editor. I discovered this entirely by reading through the bug database, as right-click doesn't work on OS X (bpo-24801).

    Some other tools use an indicator (e.g. stop sign) in the left margin, which can be toggled on and off by a simple click. This could exist in conjunction with line numbering (bpo-17535)

    @roseman roseman mannequin added topic-IDLE type-feature A feature request or enhancement labels Aug 7, 2015
    @terryjreedy
    Copy link
    Member

    bpo-24801 needs to be fixed so we can depend on right clicking. I think SET and CLEAR should be replace by TOGGLE (bpo-22083). The patch for bpo-17535 already includes marking breakpoints in the margin. I am opposed to a putting a symbol on every line. Too noisy and too confusing to beginners for an advanced feature. There are other things that could be added to a line-number context menu, such as cutting or copying a line without having to drag select it (which is too easy to mess up).

    @roseman
    Copy link
    Mannequin Author

    roseman mannequin commented Aug 7, 2015

    oh agree, definitely don't want a symbol on every line. i was already thinking implementation where you'd probably have an object matching the background for hit detection! :-)

    but yes, visually nothing there but empty space when there isn't a breakpoint, and a symbol there when the breakpoint is set

    @terryjreedy
    Copy link
    Member

    I believe one of Saimadhav's original patches used a symbol. I suggested color highlighting instead, and it seems to work better. In any case, debating such details is part of an issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant