Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ast.get_docstring to support 'async def' functions #68876

Closed
1st1 opened this issue Jul 22, 2015 · 4 comments
Closed

Fix ast.get_docstring to support 'async def' functions #68876

1st1 opened this issue Jul 22, 2015 · 4 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Jul 22, 2015

BPO 24688
Nosy @birkenfeld, @benjaminp, @1st1
Files
  • ast.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-07-23.05:56:13.179>
created_at = <Date 2015-07-22.22:13:43.528>
labels = ['type-feature', 'library']
title = "Fix ast.get_docstring to support 'async def' functions"
updated_at = <Date 2015-07-23.05:56:13.178>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2015-07-23.05:56:13.178>
actor = 'yselivanov'
assignee = 'none'
closed = True
closed_date = <Date 2015-07-23.05:56:13.179>
closer = 'yselivanov'
components = ['Library (Lib)']
creation = <Date 2015-07-22.22:13:43.528>
creator = 'yselivanov'
dependencies = []
files = ['39987']
hgrepos = []
issue_num = 24688
keywords = ['patch']
message_count = 4.0
messages = ['247154', '247163', '247169', '247170']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'benjamin.peterson', 'python-dev', 'yselivanov']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24688'
versions = ['Python 3.5', 'Python 3.6']
    @1st1
    Copy link
    Member Author

    1st1 commented Jul 22, 2015

    Please see the attached patch.

    @1st1 1st1 added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jul 22, 2015
    @benjaminp
    Copy link
    Contributor

    lgtm

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 23, 2015

    New changeset ecb13b9c4cd0 by Yury Selivanov in branch '3.5':
    Issue bpo-24688: ast.get_docstring() for 'async def' functions.
    https://hg.python.org/cpython/rev/ecb13b9c4cd0

    New changeset 5c8c88973709 by Yury Selivanov in branch 'default':
    Merge 3.5 (Issue bpo-24688)
    https://hg.python.org/cpython/rev/5c8c88973709

    @1st1
    Copy link
    Member Author

    1st1 commented Jul 23, 2015

    Thank you, Benjamin.

    @1st1 1st1 closed this as completed Jul 23, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @1st1