Upgrade windows builds to use OpenSSL 1.0.2c #68620

alex · 2015-06-11T15:05:25Z

BPO	24432
Nosy	@pfmoore, @pitrou, @larryhastings, @giampaolo, @tiran, @tjguk, @benjaminp, @ned-deily, @alex, @bitdancer, @zware, @zooba, @dstufft

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2015-07-03.22:28:01.834>
created_at = <Date 2015-06-11.15:05:25.361>
labels = ['library', 'release-blocker']
title = 'Upgrade windows builds to use OpenSSL 1.0.2c'
updated_at = <Date 2015-07-04.06:47:41.096>
user = 'https://github.com/alex'

bugs.python.org fields:

activity = <Date 2015-07-04.06:47:41.096>
actor = 'python-dev'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-07-03.22:28:01.834>
closer = 'steve.dower'
components = ['Library (Lib)']
creation = <Date 2015-06-11.15:05:25.361>
creator = 'alex'
dependencies = []
files = []
hgrepos = []
issue_num = 24432
keywords = ['security_issue']
message_count = 29.0
messages = ['245173', '245178', '245283', '246116', '246133', '246136', '246143', '246172', '246182', '246185', '246189', '246190', '246195', '246205', '246209', '246210', '246211', '246212', '246213', '246214', '246215', '246216', '246221', '246222', '246224', '246225', '246227', '246228', '246240']
nosy_count = 15.0
nosy_names = ['paul.moore', 'janssen', 'pitrou', 'larry', 'giampaolo.rodola', 'christian.heimes', 'tim.golden', 'benjamin.peterson', 'ned.deily', 'alex', 'r.david.murray', 'python-dev', 'zach.ware', 'steve.dower', 'dstufft']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue24432'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

alex · 2015-06-11T15:05:25Z

https://www.openssl.org/news/secadv_20150611.txt

ned-deily · 2015-06-11T17:56:32Z

Marking as release blocker for 3.5.0

ned-deily · 2015-06-13T02:01:52Z

Make that OpenSSL 1.0.2c now.

larryhastings · 2015-07-03T00:56:55Z

Steve?

zooba · 2015-07-03T05:09:43Z

I'll give it a shot tomorrow. Haven't done it before (not even sure I have the svn.p.o permissions). Do I still need Perl for this?

zware · 2015-07-03T05:25:05Z

Yes, you'll need Perl, NASM, and svn on PATH.

I tried to send you an email about this a week or two ago, did I not get it
sent or did it go awry?

tjguk · 2015-07-03T07:34:03Z

Zach, is there a write-up in the devguide for how to do this? And/or
could you send me the same email, please?

zware · 2015-07-03T13:08:08Z

Not yet and yes :)

zooba · 2015-07-03T14:35:29Z

There was an email, though I don't remember whether it was a detailed one.

I'll take notes as I work through it and write something up or contribute them to whoever is writing.

zooba · 2015-07-03T15:11:54Z

I assume we use svn+ssh:// for this? I can't ssh into svn.python.org with my usual key, so I'm guessing it needs to be set up on there.

Who is best to contact about that?

pitrou · 2015-07-03T15:55:14Z

For SVN access, I think it's probably Martin or perhaps Benjamin. Apparently svn.python.org still lives on the old Europe-based infrastructure...

Perhaps it would be good to switch the externals repo to hg, actually?

zware · 2015-07-03T16:04:15Z

Antoine Pitrou added the comment:

For SVN access, I think it's probably Martin or perhaps Benjamin.

Benjamin was the one who set up my access.

Perhaps it would be good to switch the externals repo to hg, actually?

Moving away from svn.python.org has been on my to-figure-out list for
some time, but like instructions for the devguide, that hasn't
happened yet either.

zooba · 2015-07-03T17:41:35Z

The advantage of svn for externals is that nobody needs the history and most people don't need a full enlistment. A hg setup should probably be one repo per project per version, and I'm not sure that's a great idea.

larryhastings · 2015-07-03T18:21:43Z

I just wanna say, thanks everybody for tackling this. Here's hoping it makes it into 3.5 beta 3!

zooba · 2015-07-03T19:22:42Z

I've emailed Benjamin, but I'm not sure when he was getting back. If I'm blocked on this then I guess Zach will have to do it again.

I got as far as building and testing for 3.5 without any issues. But if I can't check in to the repository then there's not much else I can do. Preparing the sources was smooth enough (though I added a shebang to prepare_ssl so I could run it directly).

zware · 2015-07-03T19:36:20Z

Steve: what username did you use? Try svn+ssh://pythondev@svn.python.org/external

I'm having to set things up in a new-since-last-time VM to be able to do it, so if that works before I get it done, go for it.

bitdancer · 2015-07-03T19:45:35Z

Because svn is still on the old infrastructure, it is quite possible Steve's key didn't get added to pythondev's key list. There might be someone else on infrastructure who could add it, if Benjamin isn't available.

pitrou · 2015-07-03T19:59:09Z

It turns out I have access to the machine: Steve's key is already enabled in the pythondev account.

zooba · 2015-07-03T20:21:55Z

Yep, Benjamin added it about half an hour ago :)

Should have this done fairly soon.

zware · 2015-07-03T20:22:42Z

Already have the source checked in on svn.python.org

zooba · 2015-07-03T20:33:05Z

Just spotted that. How about I kick off 3.5 and 2.7 with the old build files to test and you get 3.6 and 2.7 new?

zware · 2015-07-03T20:34:01Z

Sure, can do. I already have a test running on 3.4 as well.

zware · 2015-07-03T21:14:53Z

It all seems to work (no new failures).

zooba · 2015-07-03T21:18:10Z

Agreed. Build and obviously related tests are fine.

zware · 2015-07-03T21:27:32Z

Would you like to check it in on all branches? I'm about to be separated from my computer for a while.

zooba · 2015-07-03T21:55:30Z

Sure, I'll get it.

python-dev · 2015-07-03T22:18:01Z

New changeset 6fd63f0a0026 by Steve Dower in branch '3.4':
Issue bpo-24432: Update Windows builds to use OpenSSL 1.0.2c.
https://hg.python.org/cpython/rev/6fd63f0a0026

New changeset ebc8559b2e57 by Steve Dower in branch '3.5':
Issue bpo-24432: Update Windows builds to use OpenSSL 1.0.2c.
https://hg.python.org/cpython/rev/ebc8559b2e57

New changeset 91c5097bca2b by Steve Dower in branch 'default':
Issue bpo-24432: Update Windows builds to use OpenSSL 1.0.2c.
https://hg.python.org/cpython/rev/91c5097bca2b

python-dev · 2015-07-03T22:19:53Z

New changeset c49d2ea5e48a by Steve Dower in branch '2.7':
Issue bpo-24432: Update Windows builds to use OpenSSL 1.0.2c.
https://hg.python.org/cpython/rev/c49d2ea5e48a

python-dev · 2015-07-04T06:47:41Z

New changeset 695bbbaf2478 by Ned Deily in branch '2.7':
Issue bpo-24432: Update OS X 10.5+ installer builds to use OpenSSL 1.0.2c.
https://hg.python.org/cpython/rev/695bbbaf2478

New changeset 4b52fce3753d by Ned Deily in branch '3.4':
Issue bpo-24432: Update OS X 10.5+ installer builds to use OpenSSL 1.0.2c.
https://hg.python.org/cpython/rev/4b52fce3753d

New changeset bbf4e35ed69e by Ned Deily in branch '3.5':
Issue bpo-24432: Update OS X 10.5+ installer builds to use OpenSSL 1.0.2c.
https://hg.python.org/cpython/rev/bbf4e35ed69e

New changeset fbb9ac8aebfd by Ned Deily in branch 'default':
Issue bpo-24432: merge from 3.5
https://hg.python.org/cpython/rev/fbb9ac8aebfd

alex added the stdlib Python modules in the Lib dir label Jun 11, 2015

ned-deily added the release-blocker label Jun 11, 2015

larryhastings assigned zooba Jul 3, 2015

zware changed the title ~~Upgrade windows builds to use OpenSSL 1.0.2b~~ Upgrade windows builds to use OpenSSL 1.0.2c Jul 3, 2015

zooba closed this as completed Jul 3, 2015

ezio-melotti transferred this issue from another repository Apr 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade windows builds to use OpenSSL 1.0.2c #68620

Upgrade windows builds to use OpenSSL 1.0.2c #68620

alex commented Jun 11, 2015

alex commented Jun 11, 2015

ned-deily commented Jun 11, 2015

ned-deily commented Jun 13, 2015

larryhastings commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

tjguk commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

zooba commented Jul 3, 2015

pitrou commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

larryhastings commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

bitdancer commented Jul 3, 2015

pitrou commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

python-dev mannequin commented Jul 3, 2015

python-dev mannequin commented Jul 3, 2015

python-dev mannequin commented Jul 4, 2015

Upgrade windows builds to use OpenSSL 1.0.2c #68620

Upgrade windows builds to use OpenSSL 1.0.2c #68620

Comments

alex commented Jun 11, 2015

alex commented Jun 11, 2015

ned-deily commented Jun 11, 2015

ned-deily commented Jun 13, 2015

larryhastings commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

tjguk commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

zooba commented Jul 3, 2015

pitrou commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

larryhastings commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

bitdancer commented Jul 3, 2015

pitrou commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

zware commented Jul 3, 2015

zooba commented Jul 3, 2015

python-dev mannequin commented Jul 3, 2015

python-dev mannequin commented Jul 3, 2015

python-dev mannequin commented Jul 4, 2015