Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug refleak in set_coroutine_wrapper #68562

Closed
1st1 opened this issue Jun 3, 2015 · 3 comments
Closed

Plug refleak in set_coroutine_wrapper #68562

1st1 opened this issue Jun 3, 2015 · 3 comments
Assignees
@1st1
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@1st1
Copy link
Member

1st1 commented Jun 3, 2015

BPO 24374
Nosy @gvanrossum, @ncoghlan, @vstinner, @1st1
Files
  • set_coro.patch
  • set_coro.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
closed_at = <Date 2015-06-04.14:20:49.775>
created_at = <Date 2015-06-03.14:11:59.933>
labels = ['interpreter-core', 'type-bug']
title = 'Plug refleak in set_coroutine_wrapper'
updated_at = <Date 2015-06-04.14:20:49.774>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2015-06-04.14:20:49.774>
actor = 'yselivanov'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2015-06-04.14:20:49.775>
closer = 'yselivanov'
components = ['Interpreter Core']
creation = <Date 2015-06-03.14:11:59.933>
creator = 'yselivanov'
dependencies = []
files = ['39607', '39611']
hgrepos = []
issue_num = 24374
keywords = ['patch']
message_count = 3.0
messages = ['244749', '244808', '244823']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'ncoghlan', 'vstinner', 'python-dev', 'yselivanov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24374'
versions = ['Python 3.5', 'Python 3.6']
    @1st1
    Copy link
    Member Author

    1st1 commented Jun 3, 2015

    Code to raise RuntimeError introduced in bpo-24342 has some refleaks. Please review the attached patch.

    @1st1 1st1 self-assigned this Jun 3, 2015
    @1st1 1st1 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jun 3, 2015
    @ncoghlan
    Copy link
    Contributor

    ncoghlan commented Jun 4, 2015

    Ah, I'd missed that the previous code wouldn't clean up properly in the failure case.

    +1 for inlining the check and using the existing error label.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 4, 2015

    New changeset 3f2bf0ff262c by Yury Selivanov in branch '3.5':
    bpo-24374: Plug refleak in set_coroutine_wrapper
    https://hg.python.org/cpython/rev/3f2bf0ff262c

    New changeset 68f40b6448b9 by Yury Selivanov in branch 'default':
    bpo-24374: Plug refleak in set_coroutine_wrapper
    https://hg.python.org/cpython/rev/68f40b6448b9

    @1st1 1st1 closed this as completed Jun 4, 2015
    @1st1 1st1 added the type-bug An unexpected behavior, bug, or error label Jun 4, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @1st1 1st1

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @1st1 @ncoghlan