Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect decref in C OrderedDict #68536

Closed
ericsnowcurrently opened this issue Jun 1, 2015 · 2 comments
Closed

incorrect decref in C OrderedDict #68536

ericsnowcurrently opened this issue Jun 1, 2015 · 2 comments
Assignees
@ericsnowcurrently
Labels
release-blocker stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@ericsnowcurrently
Copy link
Member

BPO 24348
Nosy @skrah, @ericsnowcurrently, @1st1
Files
  • crash-2.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2015-06-02.05:15:22.281>
created_at = <Date 2015-06-01.16:21:56.379>
labels = ['library', 'type-crash', 'release-blocker']
title = 'incorrect decref in C OrderedDict'
updated_at = <Date 2015-06-02.05:15:22.280>
user = 'https://github.com/ericsnowcurrently'

    bugs.python.org fields:

    activity = <Date 2015-06-02.05:15:22.280>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2015-06-02.05:15:22.281>
closer = 'eric.snow'
components = ['Library (Lib)']
creation = <Date 2015-06-01.16:21:56.379>
creator = 'eric.snow'
dependencies = []
files = ['39589']
hgrepos = []
issue_num = 24348
keywords = []
message_count = 2.0
messages = ['244598', '244650']
nosy_count = 5.0
nosy_names = ['Arfrever', 'skrah', 'python-dev', 'eric.snow', 'yselivanov']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue24348'
versions = ['Python 3.5', 'Python 3.6']
    @ericsnowcurrently
    Copy link
    Member Author

    (from msg244575 in bpo-16991)

    crash-2.py is due to the fact that _PyDict_Pop() deletes a reference
    to 'key' in _odict_popkey().

    The INCREF(key) in popitem should take place before calling _odict_popkey().

    Again, I don't see the point of INCREF/DECREF *inside* of _odict_popkey().

    @ericsnowcurrently ericsnowcurrently self-assigned this Jun 1, 2015
    @ericsnowcurrently ericsnowcurrently added stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump labels Jun 1, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 2, 2015

    New changeset 8631b88c23f6 by Eric Snow in branch '3.5':
    Issue bpo-24348: Drop superfluous increfs/decrefs.
    https://hg.python.org/cpython/rev/8631b88c23f6

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ericsnowcurrently ericsnowcurrently

    Labels
    release-blocker stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @ericsnowcurrently